feat: Use Imager::zxing to read barcodes from uploaded images #9051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant `$` - Fix scope of `$ai_data_str` - Some regexes
- Ensure that more GS1 Data Link URI formats can be 'normalized' - URIs that cannot be a GS1 Data Link should not be treated as an product code
- libzxing-dev requires a the current Debian stable, bookworm. - libapache2-request-perl is only available via backports for bookworm.
test: Add first unittest for GS1 DataMatrix code Thanks to @tonycoz (TONYC on cpan) for implementing Imager::zxing!
hangy
added
barcodes
🖼️ Image upload
GS1
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9051 +/- ##
==========================================
+ Coverage 48.84% 48.99% +0.14%
==========================================
Files 66 66
Lines 20380 20398 +18
Branches 4891 4896 +5
==========================================
+ Hits 9955 9993 +38
+ Misses 9166 9138 -28
- Partials 1259 1267 +8 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
GS1
|
@hangy @alexgarel WDYT ? |
|
@hangy this could be merged now I think as we moved to the new server :-) |
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
approved these changes
Nov 29, 2023
| } | ||
| } | ||
|
|
||
| if (not(defined $code)) { |
There was a problem hiding this comment.
Suggested change
| if (not(defined $code)) { | |
| # zbar failed, try with zxing | |
| if (not(defined $code)) { |
| $code = $result->text(); | ||
| my $type = $result->format(); | ||
| $log->debug("barcode found", {code => $code, type => $type}) if $log->is_debug(); | ||
| print STDERR "scan_code code found: $code\n"; |
There was a problem hiding this comment.
Better remove this :-)
Suggested change
| print STDERR "scan_code code found: $code\n"; |
| my $type = $result->format(); | ||
| $log->debug("barcode found", {code => $code, type => $type}) if $log->is_debug(); | ||
| print STDERR "scan_code code found: $code\n"; | ||
| if (($code !~ /^\d+|(?:[\^(\N{U+001D}\N{U+241D}]|https?:\/\/).+$/)) { |
There was a problem hiding this comment.
Commenting is a must have here :-)
I'm not able to understand what the [\^(\N{U+001D}\N{U+241D}] is for !
Suggested change
| if (($code !~ /^\d+|(?:[\^(\N{U+001D}\N{U+241D}]|https?:\/\/).+$/)) { | |
| # we want a sequence of numbers, | |
| # or a url | |
| if (($code !~ /^\d+|(?:[\^(\N{U+001D}\N{U+241D}]|https?:\/\/).+$/)) { |
| ["08_gs1_databar_stacked_omni.jpg", "5010029000214"], | ||
| ["37_gs1_datamatrix.jpg", "0725272730706"], | ||
| ["43_gs1_qrcode_digital_link.jpg", "9506000134369"], | ||
| ["52_gs1_datamatrix_digital_link.jpg", "5010029000214"] |
There was a problem hiding this comment.
Suggested change
| ["52_gs1_datamatrix_digital_link.jpg", "5010029000214"] | |
| # extracted from https://id.gs1.org/01/05010029000214/10/AbC/21/666?17=301010 | |
| ["52_gs1_datamatrix_digital_link.jpg", "5010029000214"] |
| ["07_gs1_databar_stacked.jpg", "5010029000214"], | ||
| ["08_gs1_databar_stacked_omni.jpg", "5010029000214"], | ||
| ["37_gs1_datamatrix.jpg", "0725272730706"], | ||
| ["43_gs1_qrcode_digital_link.jpg", "9506000134369"], |
There was a problem hiding this comment.
Suggested change
| ["43_gs1_qrcode_digital_link.jpg", "9506000134369"], | |
| # extracted from https://dalgiardino.com/01/09506000134369/10/ABC/21/123456?17=230829 | |
| ["43_gs1_qrcode_digital_link.jpg", "9506000134369"], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use Perl module
Imager::zxingto read barcodes from images to enable support for more barcode types that are not supported byBarcode::ZBar, ie. DataMatrix. By passing the values toGS1::SyntaxEngine::FFI, this allows GS1 Data URI, GS1 DataMatrix, and GS1 QR Code barcodes to be used & parsed when uploading images to Product Opener.Related issue(s) and discussion