Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: % of fruits/vegetables for canned foods and Nutri-Score #9215

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

stephanegigandet
Copy link
Contributor

small fixes to compute the % of fruits/vegetables for canned foods (exclude water from all canned plant based foods, except canned fruits)

@stephanegigandet stephanegigandet requested a review from a team as a code owner October 27, 2023 11:15
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients categories 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis Nutri-Score labels Oct 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #9215 (0055c17) into main (0385087) will decrease coverage by 0.15%.
Report is 13 commits behind head on main.
The diff coverage is 49.18%.

@@            Coverage Diff             @@
##             main    #9215      +/-   ##
==========================================
- Coverage   47.95%   47.80%   -0.15%     
==========================================
  Files          65       65              
  Lines       20223    20292      +69     
  Branches     4914     4932      +18     
==========================================
+ Hits         9697     9701       +4     
- Misses       9271     9336      +65     
  Partials     1255     1255              
Files Coverage Δ
lib/ProductOpener/Food.pm 70.83% <ø> (ø)
lib/ProductOpener/Ingredients.pm 92.83% <100.00%> (+0.09%) ⬆️
lib/ProductOpener/TestDefaults.pm 100.00% <ø> (ø)
lib/ProductOpener/Users.pm 7.08% <0.00%> (-0.05%) ⬇️
lib/ProductOpener/Lang.pm 16.76% <0.00%> (-4.61%) ⬇️
lib/ProductOpener/Web.pm 27.34% <4.34%> (-3.85%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanegigandet stephanegigandet merged commit 67f09c1 into main Oct 30, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the nutriscore-canned-foods branch October 30, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants