taxonomy: Added unknown Croatian ingredients to the taxonomy (part 8) #9227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧬 Taxonomies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9227 +/- ##
==========================================
+ Coverage 48.14% 48.15% +0.01%
==========================================
Files 65 65
Lines 20341 20345 +4
Branches 4931 4931
==========================================
+ Hits 9794 9798 +4
Misses 9296 9296
Partials 1251 1251 ☔ View full report in Codecov by Sentry. |
teolemon
changed the title
benbenben2
changed the title
lib/ProductOpener/Ingredients.pm
Outdated
| # start by "with etc." should be added at the end of the previous ingredient | ||
| my %with = (hr => '(s | sa )',); | ||
| my $with = $with{$lc} || " will not match "; | ||
| if ($b =~ /^(s |sa )/i) { |
There was a problem hiding this comment.
Suggested change
| if ($b =~ /^(s |sa )/i) { | |
| if ($b =~ /^$with/i) { |
github-actions
bot
added
ingredients
ingredients analysis
Ingredients processing
labels
|
Kudos, SonarCloud Quality Gate passed!
|
stephanegigandet
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
issue for max: 1st ingredient is 70% min, 2nd 30% max, and there are more ingredients but estimated at 0...
https://hr.openfoodfacts.org/product/3850355006779/salakis-feta-president
Related issue(s) and discussion