feat: dq_kcal_does_not_match_exclude_more

[benbenben2]

What

Need to be reviewed carefully.

• See comments in the issue
• see how tests had to be updated (for polyols and erythritol)
• note that honeys category is under sweeteners and en:energy-value-in-kj-does-not-match-value-computed-from-other-nutrients will be shutdown for those as well

Related issue(s) and discussion

• Fixes Energy-value-in-kcal-does-not-match-value-computed-from-other-nutrients: exclude more products #7789

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba6739f) 48.18% compared to head (2cd1465) 48.81%.
Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9339      +/-   ##
==========================================
+ Coverage   48.18%   48.81%   +0.63%     
==========================================
  Files          65       66       +1     
  Lines       20348    20355       +7     
  Branches     4932     4883      -49     
==========================================
+ Hits         9805     9937     +132     
+ Misses       9288     9161     -127     
- Partials     1255     1257       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stephanegigandet]

Can you add a comment to explain why we have this condition on energy? (so that we know if we revisit it later...)

[stephanegigandet]

Instead of disabling the error, I think it would be better to change a bit the condition for the error, in case the energy is low.

(in the part # Compare to specified energy value with a tolerance of 30% + an additiontal tolerance of 5)

That way if the energy is 5, but it should be 1500, we want to have the error raised. We should add a test for that (low energy but lots of fat and sugar for instance)

[benbenben2]

Instead of disabling the error, I think it would be better to change a bit the condition for the error, in case the energy is low.

(in the part # Compare to specified energy value with a tolerance of 30% + an additiontal tolerance of 5)

That way if the energy is 5, but it should be 1500, we want to have the error raised. We should add a test for that (low energy but lots of fat and sugar for instance)

Very good suggestion.

Now, we consider either $specified_energy > 55 or $computed_energy > 55

Now, we can also ignore my previous comment in first message:
see how tests had to be updated (for polyols and erythritol)

Existing test, already covers that case:

# energy does not match nutrients
$product_ref = {
	nutriments => {
		"energy-kj_value" => 5,
		"carbohydrates_value" => 10,
		"fat_value" => 20,
		"proteins_value" => 30,
		"fiber_value" => 2,
	}
};
ProductOpener::DataQuality::check_quality($product_ref);
is($product_ref->{nutriments}{"energy-kj_value_computed"}, 1436);
ok(has_tag($product_ref, 'data_quality', 'en:energy-value-in-kj-does-not-match-value-computed-from-other-nutrients'),
	'energy not matching nutrients')
	or diag explain $product_ref;

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

Looks good, thank you!