fix: facets for EU packager codes (EC) and for users

[stephanegigandet]

• Fixes the normalization of the EC packager codes
• Also fixes Contribution count over-reported after server migration #9372

[codecov-commenter]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3726da2) 48.81% compared to head (0692fdc) 48.84%.
Report is 17 commits behind head on main.

Files	Patch %	Lines
lib/ProductOpener/Display.pm	40.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9380      +/-   ##
==========================================
+ Coverage   48.81%   48.84%   +0.02%     
==========================================
  Files          66       66              
  Lines       20355    20380      +25     
  Branches     4883     4891       +8     
==========================================
+ Hits         9937     9955      +18     
- Misses       9161     9166       +5     
- Partials     1257     1259       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexgarel]

LGTM although I don't understand how it solves the attribution bug (and don't we have any test on this ?).

[stephanegigandet]

LGTM although I don't understand how it solves the attribution bug (and don't we have any test on this ?).

The attribution bug is fixed by
my %valid_params = (code => 1, creator => 1);

This is the list of parameters that can be used as filters even though they are not tag fields.

I'll add a comment and a test.

[stephanegigandet]

@alexgarel I added a test and a comment to show that it fixes the contributors facet

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[alexgarel]

Perfect.