-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: facets for EU packager codes (EC) and for users #9380
Conversation
stephanegigandet
commented
Nov 23, 2023
- Fixes the normalization of the EC packager codes
- Also fixes Contribution count over-reported after server migration #9372
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9380 +/- ##
==========================================
+ Coverage 48.81% 48.84% +0.02%
==========================================
Files 66 66
Lines 20355 20380 +25
Branches 4883 4891 +8
==========================================
+ Hits 9937 9955 +18
- Misses 9161 9166 +5
- Partials 1257 1259 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I don't understand how it solves the attribution bug (and don't we have any test on this ?).
The attribution bug is fixed by This is the list of parameters that can be used as filters even though they are not tag fields. I'll add a comment and a test. |
@alexgarel I added a test and a comment to show that it fixes the contributors facet |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect.