Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display percent and sort options #9440

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: display percent and sort options #9440

merged 1 commit into from
Nov 30, 2023

Conversation

stephanegigandet
Copy link
Contributor

add a parameter to get % in list of tags (e.g. for Nutri-Score and Eco-Score), plus a sort_by parameter to sort by tag name or by count, with some sensible defaults

image

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@stephanegigandet stephanegigandet merged commit 90f96ee into main Nov 30, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the list_of_tags branch November 30, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants