Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move Intermarché / Les Mousquetaires import to producers platform #9474

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

stephanegigandet
Copy link
Contributor

A few things to note:

  • Intermarché wants us to remove the files from the SFTP as we process them, thus we move them to a backup folder, so that we can reprocess them if needed
  • The files are named in DD-MM-YYYY format and sometimes we get multiple months uploaded at the same second, we rename them to YYYY-MM-DD so that can import them in order
  • The CSV files are in OFF format, but they have a byte order mark which breaks Text::CSV, so we remove the mark first

@stephanegigandet stephanegigandet requested a review from a team as a code owner December 5, 2023 14:24
@github-actions github-actions bot added Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers labels Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7fb9bba) 48.84% compared to head (25bf166) 49.01%.
Report is 35 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/Import.pm 0.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9474      +/-   ##
==========================================
+ Coverage   48.84%   49.01%   +0.16%     
==========================================
  Files          66       66              
  Lines       20380    20430      +50     
  Branches     4891     4904      +13     
==========================================
+ Hits         9955    10013      +58     
+ Misses       9166     9149      -17     
- Partials     1259     1268       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@alexgarel alexgarel merged commit babb255 into main Dec 5, 2023
13 checks passed
@alexgarel alexgarel deleted the intermarche branch December 5, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants