Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more CIQUAL matches and translations #9538

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Conversation

teolemon
Copy link
Member

What

fix: more CIQUAL matches and translations

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Dec 15, 2023
# 142 in 5 languages @2021-09-21
# We disabled it because we can catch it in processing, but as a result, it does not inherit the CIQUAL property of sardines
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# We disabled it because we can catch it in processing, but as a result, it does not inherit the CIQUAL property of sardines
# We disabled it because we thought we could catch it in processing, but as a result, it does not inherit the CIQUAL property of sardines

@teolemon teolemon added the CIQUAL https://www.anses.fr/en/content/anses-ciqual-food-composition-table label Dec 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15e8cea) 49.24% compared to head (f7ba22d) 49.24%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9538   +/-   ##
=======================================
  Coverage   49.24%   49.24%           
=======================================
  Files          66       66           
  Lines       20532    20532           
  Branches     4944     4944           
=======================================
  Hits        10112    10112           
  Misses       9132     9132           
  Partials     1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member Author

error: ecoscore origin does not exist in taxonomy {origin => "IW",origin_id => "en:IW"}

error: ecoscore origin does not exist in taxonomy {origin => "SW",origin_id => "en:SW"}

error: ecoscore origin does not exist in taxonomy {origin => "US-AL",origin_id => "en:US-AL"}

error: ecoscore origin does not exist in taxonomy {origin => "US-GA",origin_id => "en:US-GA"}

error: ecoscore origin does not exist in taxonomy {origin => "US-LA",origin_id => "en:US-LA"}

error: ecoscore origin does not exist in taxonomy {origin => "US-MS",origin_id => "en:US-MS"}

error: ecoscore origin does not exist in taxonomy {origin => "US-SC",origin_id => "en:US-SC"}

error: ecoscore origin does not exist in taxonomy {origin => "US-TX",origin_id => "en:US-TX"}

error: ecoscore origin does not exist in taxonomy {origin => "WO",origin_id => "en:WO"}

error: ecoscore origin does not exist in taxonomy {origin => "Eaux internationales",origin_id => "fr:Eaux internationales"}

error: ecoscore origin does not exist in taxonomy {origin => "S\x{e3}o Tom\x{e9} e Pr\x{ed}ncipe",origin_id => "fr:S\x{e3}o Tom\x{e9} e Pr\x{ed}ncipe"}

error: ecoscore origin does not exist in taxonomy {origin => "Territoires fran\x{e7}ais du Sud",origin_id => "fr:Territoires fran\x{e7}ais du Sud"}

@teolemon teolemon requested a review from a team as a code owner December 19, 2023 11:55
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 2b49db0 into main Dec 19, 2023
12 checks passed
@stephanegigandet stephanegigandet deleted the ciqual-boost-2 branch December 19, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIQUAL https://www.anses.fr/en/content/anses-ciqual-food-composition-table 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants