Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: german additions #9542

Merged
merged 3 commits into from
Dec 17, 2023
Merged

taxonomy: german additions #9542

merged 3 commits into from
Dec 17, 2023

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Dec 16, 2023
Copy link

sonarcloud bot commented Dec 16, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97c6593) 49.02% compared to head (3526d72) 49.24%.
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9542      +/-   ##
==========================================
+ Coverage   49.02%   49.24%   +0.22%     
==========================================
  Files          66       66              
  Lines       20434    20532      +98     
  Branches     4905     4944      +39     
==========================================
+ Hits        10018    10112      +94     
+ Misses       9147     9132      -15     
- Partials     1269     1288      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -58440,7 +58446,8 @@ hr:indijski oraščić sirovi

<en:cashew nuts
en:cashew nut paste
de:Cashewpaste, Cashewnusspaste
de:Cashewpaste, Cashewnusspaste, Cashewmus
fr:pâte de noix de cajou, purée de noix de cajou
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purée de is in ingredients_processing

Suggested change
fr:pâte de noix de cajou, purée de noix de cajou
fr:pâte de noix de cajou

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I made one suggestion

@moon-rabbitOFF moon-rabbitOFF merged commit 35b2a00 into main Dec 17, 2023
12 checks passed
@moon-rabbitOFF moon-rabbitOFF deleted the german-additions branch December 17, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants