Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: fix test taxonomies #9672

Merged

Conversation

eric-nguyen-cs
Copy link
Contributor

What

Small parent id fix on the test.txt taxonomy

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Jan 18, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9db5cd4) 49.44% compared to head (7d423b8) 50.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9672      +/-   ##
==========================================
+ Coverage   49.44%   50.75%   +1.30%     
==========================================
  Files          67       67              
  Lines       20644    20644              
  Branches     4978     4978              
==========================================
+ Hits        10208    10478     +270     
+ Misses       9139     8829     -310     
- Partials     1297     1337      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eric-nguyen-cs eric-nguyen-cs changed the title fix: fix test taxonomies taxonomy: fix test taxonomies Jan 19, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 2f08865 into openfoodfacts:main Jan 24, 2024
14 checks passed
@alexgarel
Copy link
Member

Beware @eric-nguyen-cs you made a PR to a perl repository… after some time you will start to commit perl !

😁

john-gom pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants