Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: ingredients processing #9700

Merged
merged 5 commits into from
Jan 28, 2024
Merged

taxonomy: ingredients processing #9700

merged 5 commits into from
Jan 28, 2024

Conversation

teolemon
Copy link
Member

What

taxonomy: ingredients processing

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Jan 26, 2024
@teolemon
Copy link
Member Author

ERROR - pl:częściowo-uwodniony already is a synonym of pl:częściowo-uwodnione for entry en:partially-rehydrated (ingredients_processing) - pl:częściowo-uwodniony cannot be mapped to entry en:partially-hydrated / pl:częściowo-uwodniony

Software error:

Errors in the ingredients_processing taxonomy definition at /opt/product-opener/lib/ProductOpener/Tags.pm line 1496.
ERROR - pl:częściowo-uwodnione already is a synonym of pl:częściowo-uwodnione for entry en:partially-rehydrated (ingredients_processing) - pl:częściowo-uwodnione cannot be mapped to entry en:partially-hydrated / pl:częściowo-uwodniony
ERROR - pl:częściowo-uwodniona already is a synonym of pl:częściowo-uwodnione for entry en:partially-rehydrated (ingredients_processing) - pl:częściowo-uwodniona cannot be mapped to entry en:partially-hydrated / pl:częściowo-uwodniony
[Fri Jan 26 11:11:39 2024] build_lang.pl: Errors in the ingredients_processing taxonomy definition at /opt/product-opener/lib/ProductOpener/Tags.pm line 1496.

@teolemon teolemon requested a review from a team as a code owner January 26, 2024 14:54
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jan 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e90c7c4) 49.44% compared to head (b31b0cf) 49.45%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9700   +/-   ##
=======================================
  Coverage   49.44%   49.45%           
=======================================
  Files          67       67           
  Lines       20644    20645    +1     
  Branches     4978     4978           
=======================================
+ Hits        10208    10209    +1     
  Misses       9139     9139           
  Partials     1297     1297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon requested a review from aleene January 27, 2024 13:07
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Check the comment for "pl:"

Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@teolemon teolemon merged commit d98aedb into main Jan 28, 2024
12 checks passed
@teolemon teolemon deleted the ingredients-processing-2024 branch January 28, 2024 14:39
john-gom pushed a commit that referenced this pull request May 24, 2024
* taxonomy: ingredients processing

* Update labeler.yml

* Update ingredients_processing.txt

* Update taxonomies/ingredients_processing.txt

Co-authored-by: benbenben2 <[email protected]>

---------

Co-authored-by: benbenben2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update Github_actions code 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants