Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move script syncing images to s3 to product-opener #9724

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

raphael0202
Copy link
Contributor

  • move from openfoodfacts-infrastructure to openfoodfacts-server repo
  • fix the script after server migration
  • add systemd service and timer configuration files

The script runs correctly on production, but the service & timer config files have not been tested.

- move from openfoodfacts-infrastructure to openfoodfacts-server repo
- fix the script after server migration
- add systemd service and timer configuration files

The script runs correctly on production, but the service & timer
config files have not been tested.
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small comment.

On deployment we will have to setup the systemd service.

conf/systemd/[email protected] Outdated Show resolved Hide resolved
scripts/sync-s3-images/README.md Outdated Show resolved Hide resolved
@raphael0202 raphael0202 enabled auto-merge (squash) January 31, 2024 16:19
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@raphael0202 raphael0202 merged commit 46479c4 into main Jan 31, 2024
12 checks passed
@raphael0202 raphael0202 deleted the move-sync-s3-script branch January 31, 2024 16:51
john-gom pushed a commit that referenced this pull request May 24, 2024
* fix: move script syncing images to s3 to product-opener

- move from openfoodfacts-infrastructure to openfoodfacts-server repo
- fix the script after server migration
- add systemd service and timer configuration files

The script runs correctly on production, but the service & timer
config files have not been tested.

* Update conf/systemd/[email protected]

Co-authored-by: Alex Garel <[email protected]>

---------

Co-authored-by: Alex Garel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants