Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single allergen infinite loop #9757

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix: single allergen infinite loop #9757

merged 2 commits into from
Feb 6, 2024

Conversation

stephanegigandet
Copy link
Contributor

fixes #9755

Needed for this ingredient list:

"Sucre, LAIT* entier en poudre 25%, graisse végétale (palme, palmiste), beurre de cacao1, pâte de cacao1, LAIT* écrémé en poudre 3%, huile de tournesol, émulsifiant: lécithines, arômes de vanille. Traces éventuelles de fruits à coque et de céréales contenant du gluten. Cacao: 30% minimum dans le chocolat au lait. *Lait: origine UE et/ou non UE (Royaume-Uni)"

"*Lait: origine UE et/ou non UE (Royaume-Uni)" is not understood and ignored, but there is no infinite loop anymore.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a bit fragile !

Thanks for fixing.

@alexgarel alexgarel enabled auto-merge (squash) February 6, 2024 11:10
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexgarel alexgarel merged commit 50fc596 into main Feb 6, 2024
12 checks passed
@alexgarel alexgarel deleted the fix-single-allergens branch February 6, 2024 12:25
john-gom pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked Agena import on off2, 99% cpu for 6 hours
2 participants