Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UTM all mobile links #9905

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: UTM all mobile links #9905

merged 2 commits into from
Mar 12, 2024

Conversation

teolemon
Copy link
Member

What

feat: UTM all mobile links

@teolemon teolemon requested a review from a team as a code owner March 12, 2024 13:11
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Site layout labels Mar 12, 2024
@teolemon teolemon added the Road to app Ensuring we expose the value of the mobile app on the web and mobile web, and convert users. label Mar 12, 2024
@@ -50,7 +50,7 @@
<li><a href="[% edq(lang('menu_contribute_link')) %]">[% lang('menu_contribute') %]</a></li>
<li class="divider"></li>
<li><label>[% lang("add_products") %]</label></li>
<li><a href="[% edq(lang('get_the_app_link')) %]">[% lang('install_the_app_to_add_products') %]</a></li>
<li><a href="[% edq(lang('get_the_app_link')) %]&utm=pro_platform_install_the_app_to_add_products_[% language %]">[% lang('install_the_app_to_add_products') %]</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&utm should be ?utm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanegigandet fixed, thanks.

@stephanegigandet stephanegigandet enabled auto-merge (squash) March 12, 2024 13:50
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet stephanegigandet merged commit 1f65118 into main Mar 12, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the utm-all-mobile-links branch March 12, 2024 14:21
john-gom pushed a commit that referenced this pull request May 24, 2024
* feat: UTM all mobile links

* Update site_layout.tt.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Road to app Ensuring we expose the value of the mobile app on the web and mobile web, and convert users. Site layout Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants