fix: drop Encode::Punycode (no longer used) #9987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9987 +/- ##
==========================================
- Coverage 49.54% 49.47% -0.08%
==========================================
Files 67 71 +4
Lines 20650 21046 +396
Branches 4980 5047 +67
==========================================
+ Hits 10231 10412 +181
- Misses 9131 9343 +212
- Partials 1288 1291 +3 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
March 23, 2024 16:40
Base branch was modified
alexgarel
pushed a commit
to smonff/openfoodfacts-server
that referenced
this pull request
Mar 24, 2024
john-gom
pushed a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears ProductOpener::Store does not use Encode::Punycode to normalize strings but uses the tr and s instructions.