Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logo_annotation.server_type field #1396

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

raphael0202
Copy link
Collaborator

This is the same as ImageModel.server_type, but we store it here to avoid performing a double join with ImageModel table when we need to filter logos by server_type
(LogoAnnotation > ImagePrediction > ImageModel)

First step to resolve #1386

@raphael0202 raphael0202 requested a review from a team as a code owner August 19, 2024 13:29
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.06%. Comparing base (6ba5f7e) to head (22ac1ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files          80       80           
  Lines        8009     8010    +1     
=======================================
+ Hits         4490     4491    +1     
  Misses       3519     3519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is the same as ImageModel.server_type, but we store it here to
avoid performing a double join with ImageModel table when we need to
filter logos by server_type
(LogoAnnotation > ImagePrediction > ImageModel)
@raphael0202 raphael0202 force-pushed the add-logo-annotation-server-type-col branch from a21859e to 22ac1ec Compare August 19, 2024 13:38
@raphael0202 raphael0202 merged commit a318737 into main Aug 19, 2024
10 checks passed
@raphael0202 raphael0202 deleted the add-logo-annotation-server-type-col branch August 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Rewrite the query used by Hunger Games to fetch random logos
1 participant