Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make attributes tapable in the Summary card #1029

Closed
1 of 3 tasks
Tracked by #499 ...
teolemon opened this issue Jan 27, 2022 · 7 comments · Fixed by #1666
Closed
1 of 3 tasks
Tracked by #499 ...

Make attributes tapable in the Summary card #1029

teolemon opened this issue Jan 27, 2022 · 7 comments · Fixed by #1666

Comments

@teolemon
Copy link
Member

teolemon commented Jan 27, 2022

What

  • On the summary card and elsewhere, I kind of expect to be able to tap to get a proof
    • eg on the summary card, tapping on not vegan might show a new screen why it’s not vegan
    • pressing on Ultra-processed might show the ultra-processing markers + a reference to NOVA 4
  • Users also report the lack of behavior consistency with the rest of the knowledge panels
  • We need a new server side link, with the knowledge panels.
    feat: link product attributes to knowledge panels openfoodfacts-server#6493

Part of

@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 27, 2022 via email

@stephanegigandet
Copy link
Contributor

Corresponding PR on the server: openfoodfacts/openfoodfacts-server#6493

@teolemon
Copy link
Member Author

teolemon commented Mar 21, 2022

@teolemon
Copy link
Member Author

@M123-dev could you have a look at this one ?

@M123-dev
Copy link
Member

I'll have a look at it tomorrow

@M123-dev
Copy link
Member

When I understood your request right @teolemon we now expose a panel_id on the summary card and when clicked on it we should open the expanded knowledge panel for it right?

@teolemon
Copy link
Member Author

Yes, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment