Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Edit) Make it possible to edit the ingredients, product name, and packaging text in several languages #2422

Closed
3 tasks done
Tracked by #2514
teolemon opened this issue Jun 29, 2022 · 11 comments
Closed
3 tasks done
Tracked by #2514
Assignees
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users multilingual products P2

Comments

@teolemon
Copy link
Member

teolemon commented Jun 29, 2022

What

Tasks

  1. P2 multilingual products ✏️ Contribution ✏️ Editing ✏️ Editing - ingredients 🎨 Mockups available
  2. P2 multilingual products ✏️ Contribution ✏️ Editing ✏️ Editing - Basic info input 🎨 Mockups available
  3. P2 multilingual products ✏️ Contribution ✏️ Editing ✏️ Editing - Packaging input 🎨 Mockups available

Notes

  • Those fields support multilingualism
  • In the dropdown, existing languages should be listed first and differently, plus a add new language button within the dropdown

Why

  • Some country like Canada or Belgium need this

Part of

@teolemon teolemon added 📝 story ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users multilingual products and removed 📝 story labels Jun 29, 2022
@M123-dev M123-dev added the P2 label Jun 29, 2022
@M123-dev
Copy link
Member

P2 because there were many user requests

@teolemon
Copy link
Member Author

Basic details (1)

@teolemon
Copy link
Member Author

Multilingual recycling list

@teolemon teolemon changed the title Make it possible to edit the ingredients, product name, and packaging text in several languages (Edit) Make it possible to edit the ingredients, product name, and packaging text in several languages Oct 5, 2022
@teolemon teolemon added the good first issue Good for newcomers label Oct 5, 2022
@leohumnew
Copy link

Any progress on this @teolemon? It's currently much too easy to accidentally input name/ingredients in the wrong language as there's no way of changing it. I feel like it's definitely a fairly high priority issue as it prevents people in multilingual countries / multilingual people from effectively contributing, and adds a high possibility of input getting labelled as the wrong language in lots of cases. It's also a big feature regression, as it was in the old version of the app.
Hopefully someone could make some time for it at some point, I unfortunately don't have experience in mobile development 😅

@teolemon
Copy link
Member Author

teolemon commented Feb 5, 2023

Screenshot_20230205-135541.png

@monsieurtanuki
Copy link
Contributor

Hi @leohumnew!

I can see at least two problems with multi-language:

  1. I'm on a product, and I want to see the translations in all available languages
  2. I'm on a product, and I want to specify the language when I write language-specific data

I believe the biggest challenge is with 1), because when we get a product data we specify country and language as parameters: "download product 012345 as pt_BR".
And then you see the product, with Brazilian/Portuguese data.
As you specify only one language for the app, you download data for one language for a product. Of course we could download again and again for several languages, but that wouldn't be good, for UX and for development.

Would that be good for you if:

  1. you could specify several languages as "your" languages
  2. this way you would download data for all those languages
  3. this way you would see data for all those languages, provided that we add a language selector (or we display the fields in all "your" languages on the same page)
  4. this way you could write data for all those languages, using the same language selector / display all mechanism

What do you think?

@leohumnew
Copy link

leohumnew commented Feb 5, 2023

@monsieurtanuki hi!
Yes, your method does sound like a good solution! I hadn't considered that the different languages would all need to be downloaded when first loading a product to avoid downloading repeatedly in the background. And in most cases people will anyway have only 1-3 specific languages that are "theirs" as you say, so I feel like it's definitely not necessary to have a language selector which includes all languages on the products.
And then adding in a dropdown for any multi-language fields like in the mockups @teolemon did seems good (although the "language" label above it seems a bit redundant? I'm definitely not a UX designer though... 😅)

@M123-dev
Copy link
Member

M123-dev commented Feb 5, 2023

Also, if we allow specifying multiple languages as main languages, we could only show the language toggle if you have multiple ones.

I am pretty much in the middle of Germany, so I don't need to see it every time I open a page. Maybe sometimes for vacations but this is not the norm

@monsieurtanuki
Copy link
Contributor

@teolemon I suggest that instead of just one language, the user would be able to specify several languages at the app level (at init and with an "add language" button at specific places).
From now on, the user would (download and) see data that match the specified languageS.
And then be able to edit for each pre-specified language.
What are your thoughts on that suggestion?

@M123-dev
Copy link
Member

I like the idea, as we already have most of the logic for it done in off-dart we could just start and allow specifying multiple languages in the settings and then build on top of that for editing later

@monsieurtanuki monsieurtanuki self-assigned this Feb 20, 2023
@monsieurtanuki monsieurtanuki removed the good first issue Good for newcomers label Apr 9, 2023
@monsieurtanuki
Copy link
Contributor

Done in #3911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users multilingual products P2
Development

No branches or pull requests

4 participants