Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoexpand collapsed line from table when in sub-knowledge panel #2573

Closed
teolemon opened this issue Jul 11, 2022 · 2 comments · Fixed by #2581
Closed

Autoexpand collapsed line from table when in sub-knowledge panel #2573

teolemon opened this issue Jul 11, 2022 · 2 comments · Fixed by #2581
Assignees
@monsieurtanuki
Labels
📖 Knowledge panels - Table widget 📖 Knowledge panels

Comments

@teolemon
Copy link
Member

What

  • Autoexpand collapsed line from table when in sub-knowledge panel

image

Part of
@monsieurtanuki monsieurtanuki self-assigned this Jul 11, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon Just checking: we no longer display tables in the "main" product page, right? Only in the detailed pages like "nutrition data"?

@teolemon
Copy link
Member Author

Indeed, unless there's a manual override from the user

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
@monsieurtanuki
feat: openfoodfacts#2573 - KP cells are expanded on detail pages
4e3d3f6 
Impacted files:
* `knowledge_panel_card.dart`: no we are not initially expanded! (same as before)
* `knowledge_panel_element_card.dart`: refactored
* `knowledge_panel_expanded_card.dart`: refactored
* `knowledge_panel_page.dart`: yes we are initially expanded!
* `knowledge_panel_table_card.dart`: added an "initially expanded?" parameter to `TableCellWidget`
* `knowledge_panels_builder.dart`: no we are not initially expanded! (same as before)
@monsieurtanuki monsieurtanuki mentioned this issue Jul 11, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jul 19, 2022
@monsieurtanuki
feat: #2573 - KP cells are expanded on detail pages (#2581)
1eb6712 
Impacted files:
* `knowledge_panel_card.dart`: no we are not initially expanded! (same as before)
* `knowledge_panel_element_card.dart`: refactored
* `knowledge_panel_expanded_card.dart`: refactored
* `knowledge_panel_page.dart`: yes we are initially expanded!
* `knowledge_panel_table_card.dart`: added an "initially expanded?" parameter to `TableCellWidget`
* `knowledge_panels_builder.dart`: no we are not initially expanded! (same as before)
@github-actions github-actions bot mentioned this issue Jul 19, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
📖 Knowledge panels - Table widget 📖 Knowledge panels
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #2573 - Knowledge Panel cells are expanded on detail pages monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki