-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fragile interface when scan API call throws exception #628
Comments
@monsieurtanuki It doesn't happen for me, does it still happen for you? If it does, maybe your phone is affected by this: openfoodfacts/openfoodfacts-infrastructure#65 |
@stephanegigandet Good point: I tested with my old smartphone. That said, the current issue, beyond the alarming CERTIFICATE_VERIFY_FAILED message, was also about "what do we do when something ugly happens with the API?". |
…el product card New file: * `smooth_product_card_error.dart`: Product Card when an exception is caught Impacted files: * `continuous_scan_model.dart`: new value `ScannedProductState.ERROR`, used when an exception is caught during API call * `smooth_product_carousel.dart`: handling the `ScannedProductState.ERROR` case
… over internet errors New file: * `fetched_product.dart`: combo of Product and its fetch status Impacted files: * `app_en.arb`: added translations for "internet error" and "canceled by user" * `barcode_product_query.dart`: now using `FetchedProduct` instead of `Product` * `choose_page.dart`: now using `FetchedProduct` instead of `Product` * `continuous_scan_model.dart`: now using `FetchedProduct` instead of `Product` * `new_product_page.dart`: now using `FetchedProduct` instead of `Product` * `product_dialog_helper.dart`: now using `FetchedProduct` instead of `Product` * `product_page.dart`: now using `FetchedProduct` instead of `Product` * `smooth_product_card_error.dart`: added an explicit message
…t errors (#630) New files: * `fetched_product.dart`: combo of Product and its fetch status * `smooth_product_card_error.dart`: Product Card when an exception is caught Impacted files: * `app_en.arb`: added translations for "internet error" and "canceled by user" * `barcode_product_query.dart`: now using `FetchedProduct` instead of `Product` * `choose_page.dart`: now using `FetchedProduct` instead of `Product` * `continuous_scan_model.dart`: new value `ScannedProductState.ERROR`, used when an exception is caught during API call; now using `FetchedProduct` instead of `Product` * `new_product_page.dart`: now using `FetchedProduct` instead of `Product` * `product_dialog_helper.dart`: now using `FetchedProduct` instead of `Product` * `product_page.dart`: now using `FetchedProduct` instead of `Product` * `smooth_product_card_error.dart`: added an explicit message * `smooth_product_carousel.dart`: handling the `ScannedProductState.ERROR` case
(it happened this morning: does it show on Sentry?)
Describe the bug
A couple of bugs this morning:
CERTIFICATE_VERIFY_FAILED
messages in the logsCERTIFICATE_VERIFY_FAILED
To Reproduce
Steps to reproduce the behavior:
Bug 1 with barcode scan:
Bug 2 with keyword search:
CERTIFICATE_VERIFY_FAILED
Expected behavior
Bug 1:
Bug 2:
Screenshots
Bug 1:
Bug 2:
Logs
The text was updated successfully, but these errors were encountered: