Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have proper spaces between brands after commas #770

Closed
2 tasks
Tracked by #1265
teolemon opened this issue Dec 27, 2021 · 5 comments · Fixed by #3089
Closed
2 tasks
Tracked by #1265

Ensure we have proper spaces between brands after commas #770

teolemon opened this issue Dec 27, 2021 · 5 comments · Fixed by #3089
Assignees
Labels
Milestone

Comments

@teolemon
Copy link
Member

  • Nitpicking (ensure we have proper spaces after commas, all the time). What's weird is that the first example looks ok :-/
    • image
@teolemon teolemon added the P5 label Jan 14, 2022
@teolemon teolemon added this to the V1.1 milestone Apr 15, 2022
@teolemon teolemon changed the title Nitpicking (ensure we have proper spaces after commas, all the time) Ensure we have proper spaces between brands after commas Aug 7, 2022
@WildOrangutan
Copy link
Contributor

I can work on this

@M123-dev
Copy link
Member

M123-dev commented Oct 1, 2022

Great @WildOrangutan

@WildOrangutan
Copy link
Contributor

Scratching my head how to address this. This falls into category of auto-correct. In this case it was a missing space after comma, but it may as well be mistyped brand name.

I could take "bob is your uncle" approach, and simply add space after comma, when user inputs text. But that seems hacky to me, since comma is not universal between languages.

Am I overthinking this?

@monsieurtanuki
Copy link
Contributor

I would just make sure that each comma is followed by one and only one space, at display time.

@VaiTon
Copy link
Member

VaiTon commented Oct 3, 2022

I would just make sure that each comma is followed by one and only one space, at display time.

Yeah exactly. @WildOrangutan you could try to split at ','; trim every string and then join to a string with ', '. If we fail we just display the original value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

5 participants