-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correctly format commas between product brands #3089
fix: Correctly format commas between product brands #3089
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3089 +/- ##
==========================================
- Coverage 6.46% 6.46% -0.01%
==========================================
Files 246 246
Lines 12197 12207 +10
==========================================
Hits 789 789
- Misses 11408 11418 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
packages/smooth_app/lib/pages/product/add_basic_details_page.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have very limited expierence with regular expressions, but this seems about right to me. Thanks for a lot for this fix @WildOrangutan
I'd say we merge here and if there are problems with bad data from translators we can always improve upon
What
Correctly format commas between product brands.
Screenshot
Fixes bug(s)
Fixes: #770