Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly format commas between product brands #3089

Merged
merged 3 commits into from
Oct 5, 2022
Merged

fix: Correctly format commas between product brands #3089

merged 3 commits into from
Oct 5, 2022

Conversation

WildOrangutan
Copy link
Contributor

@WildOrangutan WildOrangutan commented Oct 3, 2022

What

Correctly format commas between product brands.

Screenshot

image

Fixes bug(s)

Fixes: #770

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #3089 (417358b) into develop (de3b7bb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #3089      +/-   ##
==========================================
- Coverage     6.46%   6.46%   -0.01%     
==========================================
  Files          246     246              
  Lines        12197   12207      +10     
==========================================
  Hits           789     789              
- Misses       11408   11418      +10     
Impacted Files Coverage Δ
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)
...cards/product_cards/smooth_product_card_found.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/helpers/product_cards_helper.dart 0.00% <0.00%> (ø)
..._app/lib/pages/product/add_basic_details_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have very limited expierence with regular expressions, but this seems about right to me. Thanks for a lot for this fix @WildOrangutan

I'd say we merge here and if there are problems with bad data from translators we can always improve upon

@M123-dev M123-dev merged commit 2229365 into openfoodfacts:develop Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure we have proper spaces between brands after commas
5 participants