Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added button for missing basic details #1272

Merged
merged 4 commits into from
Mar 20, 2022
Merged

Added button for missing basic details #1272

merged 4 commits into from
Mar 20, 2022

Conversation

vik4114
Copy link
Contributor

@vik4114 vik4114 commented Mar 20, 2022

What

Screenshot

Before
2022-03-20 at 2 56 43 PM

After
2022-03-20 at 2 56 44 PM

Part of

@vik4114 vik4114 requested a review from a team as a code owner March 20, 2022 09:33
M123-dev
M123-dev reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for the button looks good @vik4114, but a button without any response is confusing. It would be good if you at least show a snackbar with "Not implemented yet" or something like that.

@vik4114
Copy link
Contributor Author

vik4114 commented Mar 20, 2022

@M123-dev Off course

M123-dev
M123-dev approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @vik4114, we should still implement the page in near time.

@M123-dev M123-dev merged commit 39ea391 into openfoodfacts:develop Mar 20, 2022
@M123-dev
Copy link
Member

Congrats on your first pull request here @vik4114 🎉

@github-actions github-actions bot mentioned this pull request Mar 20, 2022
Closed
@vik4114
Copy link
Contributor Author

vik4114 commented Mar 20, 2022

@M123-dev Thanks. There are more to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vik4114 @M123-dev @teolemon