Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navigate to add basic details page if scanned product is unknown #1778

Merged
merged 2 commits into from
May 7, 2022
Merged

fix: Navigate to add basic details page if scanned product is unknown #1778

merged 2 commits into from
May 7, 2022

Conversation

bhattabhi013
Copy link
Contributor

@bhattabhi013 bhattabhi013 commented May 7, 2022

What

Added navigation to AddBasicDetailsPage in case of a product with an unknown name.

Screenshot

1428.mp4

Fixes bug(s)

Fixes #1428

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner May 7, 2022 05:38
@codecov-commenter
Copy link

Codecov Report

Merging #1778 (9b084a1) into develop (2ea0da3) will decrease coverage by 0.76%.
The diff coverage is 0.57%.

@@            Coverage Diff             @@
##           develop   #1778      +/-   ##
==========================================
- Coverage     8.86%   8.10%   -0.77%     
==========================================
  Files          161     168       +7     
  Lines         6623    7345     +722     
==========================================
+ Hits           587     595       +8     
- Misses        6036    6750     +714     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9518e2e...9b084a1. Read the comment docs.

@teolemon
Copy link
Member

teolemon commented May 7, 2022

great 👍 Adding a link in the full edit mode and in product addition screen would complete the picture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants