Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1787 - SMOOTHIE-V9 #1791

Merged
merged 1 commit into from
May 9, 2022
Merged

fix: #1787 - SMOOTHIE-V9 #1791

merged 1 commit into from
May 9, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • knowledge_panel_page.dart: handled the case when panel.titleElement==null

What

  • App used to crash in the rare cases when panel.titleElement==null
  • the current PR fixes that

Fixes bug(s)

Fixes: #1787
Fixes SMOOTHIE-V9

@monsieurtanuki
fix: openfoodfacts#1787 - SMOOTHIE-V9
47460e7 
Impacted file:
* `knowledge_panel_page.dart`: handled the case when `panel.titleElement==null`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner May 9, 2022 08:51
@monsieurtanuki monsieurtanuki merged commit 90e2837 into openfoodfacts:develop May 9, 2022
@github-actions github-actions bot mentioned this pull request May 9, 2022
Closed
@monsieurtanuki monsieurtanuki mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_CastError: Null check operator used on a null value
2 participants
@monsieurtanuki @M123-dev