-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2362 history not refreshing #2393
fix: #2362 history not refreshing #2393
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2393 +/- ##
==========================================
- Coverage 8.86% 7.52% -1.35%
==========================================
Files 161 204 +43
Lines 6623 9770 +3147
==========================================
+ Hits 587 735 +148
- Misses 6036 9035 +2999
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again @cli1005!
Looks like it solves the issue.
Not a big fan of the added parameter needNotify
. I would just call daoProductList.localDatabase.notifyListeners()
after _daoProductList.push(_history, _latestFoundBarcode!);
, and not use that extra parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cli1005!
In general, I would say that in Smoothie we're not good with providers and notifications. That would require a specific issue about who we should notify and when, but that's another story.
A update on openfoodfacts broke the Pre-submits test check, KnowledgePanelElementType has a new type ACTION? should we do something for adapting? |
@cli1005 Sure we should do something:
|
@cli1005 I'm working on the fix. |
Issue for long time fix |
develop has been fixed and merged, so merging this one. |
What
Screenshot
RPReplay-Final1656320604.mov
RPReplay-Final1656320080.MP4
Fixes bug(s)