-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Camera fixes #2409
fix: Camera fixes #2409
Conversation
47934ea
to
dd5f379
Compare
import 'package:smooth_app/pages/scan/camera_controller.dart'; | ||
|
||
/// Forked Widget from the [camera] library, but with a simpler Widget | ||
class CameraStreamPreview extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class CameraStreamPreview extends StatelessWidget { | |
class SmoothCameraStreamPreview extends StatelessWidget { |
So that it's clear that we have it locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will change that @M123-dev.
The PR is right now in draft to let @AshAman999 test if a fix is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flash issues seemed to have resolved but the camera was going blank after I take a picture and had to restart my app to start it again, tried it multiple times faced the same issues (for ingredients picture update here in this case )
Android 11,
screen-20220628-222230.mp4
Many changes are in place in my last commit. cc @AshAman999 @stephanegigandet @teolemon |
0aab075
to
54128e5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2409 +/- ##
==========================================
- Coverage 8.86% 7.49% -1.38%
==========================================
Files 161 206 +45
Lines 6623 9837 +3214
==========================================
+ Hits 587 737 +150
- Misses 6036 9100 +3064
Continue to review full report at Codecov.
|
Tried the build just now, still facing the same issues
[Android 11] |
Just to be sure, did you do a flutter pub upgrade before? What exactly is your device? |
Some suggestions:
Sorry if my suggestions are irrelevant; I didn't follow all the camera issue threads. |
For the Just to be sure @AshAman999, could you test with this APK: https://appdistribution.firebase.dev/i/0b903c4d20f393a2 |
Looks good this time, |
As feedbacks seem positive, I will finalize the PR |
It seems that @stephanegigandet had regressions on Samsung devices ? |
No finally it was OK |
54128e5
to
b32e385
Compare
It seems that these changes are OK. Will it be our last episode of the scanner series? I hope so… |
ok, merging. Thank you @g123k 🙏 |
Will fix #2394 #2399 #2398