feat: #1136 - handle "action" elements in KP #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `add_category_button.dart`: "Add category" button for user contribution. * `add_ingredients_button.dart`: "Add ingredients" button for user contribution. * `add_nutrition_button.dart`: "Add nutrition facts" button for user contribution. * `knowledge_panel_action_card.dart`: "Contribute Actions" for the knowledge panels. Impacted files: * `knowledge_panel_card.dart`: refactored. * `knowledge_panel_element_card.dart`: action "actions" element; refactored. * `knowledge_panel_expanded_card.dart`: refactored. * `knowledge_panel_group_card.dart`: refactored. * `knowledge_panel_page.dart`: refactored. * `knowledge_panel_page_template.dart`: refactored. * `knowledge_panels_builder.dart`: added an explicit `bool onboardingMode` field; used new classes `AddNutritionButton` and `AddIngredientsButton`; refactored. * `new_product_page.dart`: refactored. * `summary_card.dart`: used new class `AddCategoryButton`; refactored.
teolemon
added
📖 Knowledge panels
🛣️ Road to scores
|
Great @monsieurtanuki 👍 A nice loop for the road to scores |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
add_category_button.dart: "Add category" button for user contribution.add_ingredients_button.dart: "Add ingredients" button for user contribution.add_nutrition_button.dart: "Add nutrition facts" button for user contribution.knowledge_panel_action_card.dart: "Contribute Actions" for the knowledge panels.Impacted files:
knowledge_panel_card.dart: refactored.knowledge_panel_element_card.dart: action "actions" element; refactored.knowledge_panel_expanded_card.dart: refactored.knowledge_panel_group_card.dart: refactored.knowledge_panel_page.dart: refactored.knowledge_panel_page_template.dart: refactored.knowledge_panels_builder.dart: added an explicitbool onboardingModefield; used new classesAddNutritionButtonandAddIngredientsButton; refactored.new_product_page.dart: refactored.summary_card.dart: used new classAddCategoryButton; refactored.What
Screenshot
[edit:add] barcode 4006922007543, in English
Impact: the "could you..." text and the buttons:
For the record, the product page:
Fixes bug(s)