Fix rounding issues by upgrading decimal maths library #12950
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macanudo527
force-pushed
the
unlock_bigdecimal
branch
from
eea6606
to
31c8543
Compare
4 tasks
macanudo527
force-pushed
the
unlock_bigdecimal
branch
2 times, most recently
from
ef8aeb4
to
ae0b460
Compare
rioug
reviewed
Oct 29, 2024
dacook
approved these changes
Oct 30, 2024
mkllnk
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Nice one!
I'm glad we have this in a separate pull request now because there's quite a bit to discuss. Awesome work and I think that this update will fix some rounding bugs in our app as well. I just have two little requests to make the code more readable and robust. Otherwise good to go.
mkllnk
added
the
user facing changes
mkllnk
changed the title
macanudo527
force-pushed
the
unlock_bigdecimal
branch
2 times, most recently
from
ac4aa32
to
511aff9
Compare
rioug
approved these changes
Nov 3, 2024
macanudo527
force-pushed
the
unlock_bigdecimal
branch
2 times, most recently
from
636868a
to
b79acf3
Compare
|
@mklink is there anything else needed for this one? |
dacook
approved these changes
Nov 12, 2024
macanudo527
force-pushed
the
unlock_bigdecimal
branch
from
b79acf3
to
7a5074c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
BigDecimal was version locked, but with some small modifications to a test and another small modification to display logic, it doesn't need to be. This allows us to use default gems on Alpine Docker images much easier. It also allows dependabot to automatically upgrade the gem when necessary.
What should we test?
truncto create the value instead ofround.Release notes
BigDecimal will now be updated to the latest version more easily.
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.