Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParameterHandler.add_parameter docstring #970

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

mattwthompson
Copy link
Member

Small fix (#606) that I didn't get to earlier.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #970 (a58421a) into master (600ebb3) will not change coverage.
The diff coverage is n/a.

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@mattwthompson mattwthompson merged commit 512fdd2 into master Jun 4, 2021
@mattwthompson mattwthompson deleted the fix-606 branch June 4, 2021 19:03
@Yoshanuikabundi
Copy link
Collaborator

Hey @mattwthompson! Sorry I didn't get to review this before it merged --- looks like you're writing in Markdown, and unfortunately the docstrings are still parsed as ReST, so we've got things like italics where you meant code and a broken link.

Converting the existing docstrings to Markdown is obviously a big job, and the tooling for parsing doesn't exist yet anyway unless we want to give up things like cross references or ditch Sphinx altogether. So we're probably stuck with ReST for a little while yet.

@mattwthompson
Copy link
Member Author

Hmm, I must not have looked at the actual source before merging:

image

I think in this case the only differences are single to double backticks and fixing the link?

@Yoshanuikabundi
Copy link
Collaborator

I think so! I had a good look into enabling markdown for docstrings yesterday and the support really isn't there. Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants