Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double values can be entered in integer fields #173

Closed
maxmentha opened this issue Sep 25, 2017 · 4 comments
Closed

Double values can be entered in integer fields #173

maxmentha opened this issue Sep 25, 2017 · 4 comments

Comments

@maxmentha
Copy link

When the user creates a new feature and fills the attribute table, he can enter data that does not have the correct format without being warned about it, and without the app to prevent this from happening. For example, if a field is defined as a double real number, but with a scale of 0, the user can still enter numbers with decimals when digitizing. However, they will be saved with the scale that was defined at the creation of the field. This leads to a loss of information that goes unnoticed at the moment of the digitalization.

Reproduction Steps:

  1. create a shapefile with a real/double field with scale 0
  2. enter data with decimals
  3. the data gets lost...

Expected behavior:

warning or impossibility to save invalid data

Observed behavior:

data gets saved with defined scale, without any warning

Screenshots and GIFs

QField version: 0.10.1

Additional information:

  • Problem started happening recently, didn't happen in an older version of QField: ?
  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
  • Problem happens with all files and projects, not only some files or projects: [Yes]
@saemiw
Copy link

saemiw commented Sep 25, 2017

I can confirm this. It happend during some field work of us where we entered double values into an accidentally as integer define field. All the decimal information was lost. It would of course be nice if QField could somehow show a warning when this is the case.

@m-kuhn m-kuhn changed the title Qfield allows to enter non-valid data when digitizing Double values can be entered in integer fields Sep 25, 2017
@m-kuhn
Copy link
Member

m-kuhn commented Sep 25, 2017

When the user creates a new feature and fills the attribute table, he can enter data that does not have the correct format without being warned about it, and without the app to prevent this from happening. For example ...

Is it only the double/integer issue or are there other ones as well?

@saemiw
Copy link

saemiw commented Sep 29, 2017

I'll have list of potential bugs that I will check hopefully mid-october. I will then also check if this issue is relevant for other data types. For the moment I am only aware of the above mentioned.

@saemiw
Copy link

saemiw commented Oct 25, 2017

There are some other issues (date for example does not save integer, decimal values). This is probably not so problematic. BUT it would of course be nice to have a warning for all the fields if the entry doesn't correspond to the datatype defined.

For me the most urgent one is clearly integer/decimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants