Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topping Exporter: Consider the layer type for style categories #966

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Topping Exporter: Consider the layer type for style categories #966

merged 2 commits into from
Oct 10, 2024

Conversation

signedav
Copy link
Member

@signedav signedav commented Oct 7, 2024

And with newer QGIS use the exposed QGIS model and delegate to make it beautiful:

image

Requires qgis/QGIS#58729

gacarrillor
gacarrillor approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@gacarrillor gacarrillor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I'm not 100% sure of my review here, since I couldn't test it in GUI, but in general, it looks good to me.

@signedav signedav merged commit a8f2cf1 into master Oct 10, 2024
7 checks passed
@signedav signedav deleted the categoriesexporter branch October 10, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gacarrillor gacarrillor gacarrillor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@signedav @gacarrillor