[shelly] Improve devices discovery for protected devices #15399
Assignees
Labels
enhancement
An enhancement or new feature for an existing add-on
PR pending
There is a pull request for resolving the issue
Comments
markus7017
added
enhancement
markus7017
added a commit
to markus7017/openhab-addons
that referenced
this issue
Aug 10, 2023
…lly to retrieve device attributes, thing discovery is now based on reported device model id rather than service name. If is not recognized the service name will be used as fallback. Even password protected things are now created with the thing type matching the model rather than shellydevice, which is still supported for backward compatibility. - openhab#15398: Discovery result now uses representation property serviceName rather than deviceName, which could case strange effects when adding things from the Inbox - openhab#15397: Security fix for Gen1: We don’t expose basic auth (BASE64 encoded password) anymore when not requested by the device (/shelly.auth = true). Gen2 uses digest authentication, which is not affected by this issues. - openhab#15392: Version detection for Gen2 devices is fixed and now also handles beta versions correctly (e.g. 1.0.0-beta6), they are displayed correctly in Shelly Manager - openhab#15359: Shelly BLU Motion is supported - openhab#15396: Cleanup in Shelly Manager for actions and firmware upgrade, which currently can’t be supported by the binding. - openhab#15395: Gen2: Do not try to install BLU script on battery devices like PlusHT - openhab#15394: CoIoT attribute boost mode is now processed and results in a channel update - openhab#15393: Fix for TRV target temp not being initialized - openhab#15392 Gen2: Upgrade to beta firmware by device fixed - Code cleanup of duplicate device attributes, which causes a bunch of dummy changes (/referred variables names have changed) - README updated Signed-off-by: Markus Michels <[email protected]>
markus7017
added a commit
to markus7017/openhab-addons
that referenced
this issue
Aug 10, 2023
related to device discovery and initialization as well as BLU motion support. The other topics are small fixes, we were able to catch a bunch of them. - openhab#15399: Rework device discovery and initialization: Use /shelly to retrieve device attributes, thing discovery is now based on reported device model id rather than service name. If is not recognized the service name will be used as fallback. Even password protected things are now created with the thing type matching the model rather than shellydevice, which is still supported for backward compatibility. - openhab#15398: Discovery result now uses representation property serviceName rather than deviceName, which could case strange effects when adding things from the Inbox - openhab#15397: Security fix for Gen1: We don’t expose basic auth (BASE64 encoded password) anymore when not requested by the device (/shelly.auth = true). Gen2 uses digest authentication, which is not affected by this issues. - openhab#15392: Version detection for Gen2 devices is fixed and now also handles beta versions correctly (e.g. 1.0.0-beta6), they are displayed correctly in Shelly Manager - openhab#15359: Shelly BLU Motion is supported - openhab#15396: Cleanup in Shelly Manager for actions and firmware upgrade, which currently can’t be supported by the binding. - openhab#15395: Gen2: Do not try to install BLU script on battery devices like PlusHT - openhab#15394: CoIoT attribute boost mode is now processed and results in a channel update - openhab#15393: Fix for TRV target temp not being initialized - openhab#15392 Gen2: Upgrade to beta firmware by device fixed - Code cleanup of duplicate device attributes, which causes a bunch of dummy changes (/referred variables names have changed) - README updated Signed-off-by: Markus Michels <[email protected]>
|
Closed by #15898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For now the binding discovers devices dynamically. If the are password protected and the credentials do not match the defaults from the binding config the thing gets created using thing type shellydevice. When the user then enters the correct credentials in the thing config the thing type is changed, but shellydevice is still referenced in the thing uid.
This has been improved to use the information from /shelly and create the corresponding correct thing type (not shellydevice, which is still supported for backward compatibility)
The text was updated successfully, but these errors were encountered: