Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[influxdb] Handle exceptions gracefully #15062

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[influxdb] Handle exceptions gracefully #15062

merged 2 commits into from
Jun 13, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jun 8, 2023

As reported on the forum (https://community.openhab.org/t/oh4-m2-m3-influxdb-restoreonstartup-fails-timeout-exceptions-in-startup-logs/146915)the influx persistence service does not properly handle exceptions.

This does NOT fix the reported issue, but it prevents the persistence service from crashing and flooding the log with stack traces. The original issue seems to be a connection issue where the socket times out.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jun 8, 2023
@J-N-K J-N-K requested a review from lujop as a code owner June 8, 2023 17:50
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh4-m2-m3-influxdb-restoreonstartup-fails-timeout-exceptions-in-startup-logs/146915/2

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A stacktrace of an exception during write can be found in #15092.

@fwolter fwolter added this to the 4.0 milestone Jun 13, 2023
@fwolter fwolter merged commit d2e10ab into openhab:main Jun 13, 2023
@J-N-K J-N-K deleted the influx branch June 13, 2023 20:04
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
* [influxdb] Handle exceptions gracefully

Signed-off-by: Jan N. Klug <[email protected]>

* also catch InfluxDBIOExceptions

Signed-off-by: Jan N. Klug <[email protected]>

---------

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
* [influxdb] Handle exceptions gracefully

Signed-off-by: Jan N. Klug <[email protected]>

* also catch InfluxDBIOExceptions

Signed-off-by: Jan N. Klug <[email protected]>

---------

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [influxdb] Handle exceptions gracefully

Signed-off-by: Jan N. Klug <[email protected]>

* also catch InfluxDBIOExceptions

Signed-off-by: Jan N. Klug <[email protected]>

---------

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants