[senechome] Fix for Senec firmware update #15535

querdenker2k · 2023-09-01T20:20:11Z

Senec updated the Firmware which changes the protocol from http to https and disabled historic data access.
I added a new thing config parameter useHttp for legacy usage if some modules are not updated.

Edit:

also removes 7 channels due to Senec local web ui change.

eguib · 2023-09-05T20:28:55Z

Are you sure about the removal of the "STATISTIC" block?
Querying lala.cgi with {"STATISTIC":{}} just returns an empty JSON with status=200 and not an "OBJECT NOT FOUND" as for really unknown JSON object requests!?
Any idea what auth is required to access /vars.html? Would be really helpful to understand what changed ...

Update: querying lala.cgi with {"DEBUG":{}} returns all sections and that list still contains "STATISTIC", so maybe just a bug that the returned block is empty?

eguib · 2023-09-06T20:14:31Z

Another update:
noauth access to log/vars still works if one uses "Log/YYYY/MM/DD.log" or "Vars.html"
But there are no new insights regarding "STATISTIC" :-(

vich-667 · 2023-09-10T22:06:27Z

Will solve issue #15524

lolodomo · 2023-10-18T20:28:16Z

This PR seems also to remove 7 channels. Why isn't it mentioned in PR description?

vich-667 · 2023-10-20T12:23:04Z

This PR seems also to remove 7 channels. Why isn't it mentioned in PR description?

Yes, Senec unfortunately removed that values from the local web UI. Therefore this cannels doen't work for a while. It's basically a cleanup.

...hab.binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeApi.java

...binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandler.java

...hab.binding.senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeApi.java

....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java

bundles/org.openhab.binding.senechome/README.md

....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java

bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Jacob Laursen <[email protected]>

Signed-off-by: Ben Rosenblum <[email protected]>

* Add support for Move 2 Resolves openhab#15702 --------- Signed-off-by: Jacob Laursen <[email protected]>

Signed-off-by: Wouter Born <[email protected]>

Signed-off-by: Holger Friedrich <[email protected]>

* Solves issue openhab#15684 * Removing excessive usage of inline typecast --------- Signed-off-by: clinique <[email protected]>

* Convert to OH jetty HttpClient * Adds a Stack for HttpClient storage * Add synchronized to prevent exception * fix binding * Stop stack on close * Resolves exception on registring forward actions * Reduces client count to 5 to align to expected thread pool limit of 5 --------- Signed-off-by: Ben Rosenblum <[email protected]> Co-authored-by: Mark Herwege <[email protected]>

* Adding the possibility to disable websocket listening. This is set up in order to ease debugging of the "Erreur Interne" issue. * Enhancing websocket work with recurrent deconnection, simplification of listeners handling * refactored function name * Fixed the name of the channel where the refresh command is sent. * Solving SAT issues * Corrected doc error * Added properties * Removed gson 2.10 now that it is included into core. --------- Signed-off-by: clinique <[email protected]>

If the client is not stopped it will not be garbage collected because the ShutdownThread keeps a reference to the client so it can be stopped on shutdowns. See: https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java#L420-L433 Signed-off-by: Wouter Born <[email protected]>

* [jythonscripting] Add a note not to use jython * [jythonscripting] Mark as deprecated --------- Signed-off-by: Jimmy Tanagra <[email protected]>

…penhab#15720) This reverts commit 72622a1. Signed-off-by: Jacob Laursen <[email protected]>

The dependency change in openhab#15659 caused slf4j to be embedded into the bundle. As a result the bundle no longer uses Pax Logging so it cannot find an SLF4J provider and logs the following when it is installed: SLF4J: No SLF4J providers were found. SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details. Signed-off-by: Wouter Born <[email protected]>

… in order (openhab#15530) Signed-off-by: Anton Hattendorf <[email protected]>

If the client is not stopped it will not be garbage collected because the ShutdownThread keeps a reference to the client so it can be stopped on shutdowns. See: https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java#L420-L433 Signed-off-by: Wouter Born <[email protected]>

* Fix problem with DPT 251.600. In the old implementation the datatype was implemented with byte 0-255. The DPT 251.600 is defined with 0-100%, change this from byte to PercentType. Signed-off-by: Marco Mueller <[email protected]>

Upgrades H2 database from 1.4.191 to 2.2.224. Add ';NON_KEYWORDS=VALUE' to the JDBC URL because the add-on uses 'value' (which is also a keyword) as column name. Also fixes some queries used by the command extension because H2 always uses upper case table names. For the change log, see: https://h2database.com/html/changelog.html For migration notes, see: https://h2database.com/html/migration-to-v2.html Fixes openhab#13115 Signed-off-by: Wouter Born <[email protected]>

Signed-off-by: Florian Hotze <[email protected]>

Signed-off-by: Jimmy Tanagra <[email protected]>

lsiepel · 2023-10-29T09:25:36Z

is here something to do for me? i don't know how to remove the other commits (which are from main) from this mr

I think the PR got fixed; All the excess reviewers got removed, review comments are addressed etc. Maybe @lolodomo needs anothe review pass, but nothing you can do at the moment to speed up merging.

bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/thing/thing-types.xml

lolodomo

Here are new and final review comments

....senechome/src/main/java/org/openhab/binding/senechome/internal/SenecHomeHandlerFactory.java

bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/i18n/senechome.properties

bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/update/instructions.xml

…F/thing/thing-types.xml Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Robert D. <[email protected]>

Signed-off-by: querdenker2k <[email protected]>

…or-senec-update

Signed-off-by: querdenker2k <[email protected]>

lolodomo

LGTM, thank you

lolodomo · 2023-11-11T11:59:45Z

DCO is KO probably due to wrong usage of git rebase. I am going to squash everything and keep the proper sign-off-by.

lolodomo · 2023-11-11T12:03:35Z

@jlaur @wborn : I don't know what to do with this PR. When I try to merge it, I see a very long list of commits including some coming from other bindings. This PR is certainly not clean. I don't know what is the risk to merge it. Can you help me to evaluate the risk please ?

wborn · 2023-11-11T12:45:53Z

Probably you only need to cleanup the commit message and the squashed commit should look like https://github.com/openhab/openhab-addons/pull/15535/files

lolodomo · 2023-11-11T13:02:54Z

A real nightmare, the merge message was containing probably several hundreds of lines. I just kept two lines.

wborn · 2023-11-11T13:09:10Z

Maybe @querdenker2k can have a look at the linked community post in the PR template next time:

ATTENTION: Don't use "git merge" when working with your pull request branch!
This can clutter your Git history and make your PR unusable.
Use "git rebase" instead. See this forum post for further details:
https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358

* Fix for Senec update Signed-off-by: querdenker2k <[email protected]>

* Fix for Senec update Signed-off-by: querdenker2k <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>

querdenker2k requested a review from vctender as a code owner September 1, 2023 20:20

querdenker2k mentioned this pull request Sep 1, 2023

[senechome] Cannot connect after firmware update #15524

Closed

KorbinianP mentioned this pull request Sep 8, 2023

[SenecHome] Enable HTTPS usage for Senec Binding #15558

Closed

lsiepel linked an issue Sep 16, 2023 that may be closed by this pull request

[senechome] Cannot connect after firmware update #15524

Closed

vich-667 approved these changes Oct 1, 2023

View reviewed changes

lolodomo requested changes Oct 21, 2023

View reviewed changes

lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Oct 21, 2023

jlaur and others added 18 commits October 21, 2023 21:03

[hue] Cleanup code (openhab#15715)

77c4cb5

Signed-off-by: Jacob Laursen <[email protected]>

Adds DDPlus20 and an additional ID for DD20 (openhab#15712)

0036bf0

Signed-off-by: Ben Rosenblum <[email protected]>

[sonos] Add support for Move 2 (openhab#15706)

4ac25eb

* Add support for Move 2 Resolves openhab#15702 --------- Signed-off-by: Jacob Laursen <[email protected]>

Resolve runbundles for JUnit upgrade (openhab#15714)

fbb0c00

Signed-off-by: Wouter Born <[email protected]>

Improve javadoc for some addons (openhab#15701)

8a06cb1

Signed-off-by: Holger Friedrich <[email protected]>

[Netatmo] Avoid double refresh of weather channels (openhab#15686)

a4ff81d

* Solves issue openhab#15684 * Removing excessive usage of inline typecast --------- Signed-off-by: clinique <[email protected]>

[jythonscripting] Add a note not to use jython (openhab#15623)

bdb53e3

* [jythonscripting] Add a note not to use jython * [jythonscripting] Mark as deprecated --------- Signed-off-by: Jimmy Tanagra <[email protected]>

Revert "[shelly] Always try to stop WebSocketClient (openhab#15719)" (o…

a3ff265

…penhab#15720) This reverts commit 72622a1. Signed-off-by: Jacob Laursen <[email protected]>

Fix openhab#15514: Temperature sensors in JSON from shelly may not be…

a6a2179

… in order (openhab#15530) Signed-off-by: Anton Hattendorf <[email protected]>

[knx] Bugfix problem with DPT 251.600 (openhab#15723)

fbc895f

* Fix problem with DPT 251.600. In the old implementation the datatype was implemented with byte 0-255. The DPT 251.600 is defined with 0-100%, change this from byte to PercentType. Signed-off-by: Marco Mueller <[email protected]>

[persistence] Capitalize add-on names (openhab#15378)

8983b87

Signed-off-by: Florian Hotze <[email protected]>

[jrubyscripting] Inject script context as global (openhab#15618)

2a82953

Signed-off-by: Jimmy Tanagra <[email protected]>

lsiepel removed request for lsiepel, Confectrician, Stratehm, stefanroellin, niklasdoerfler, gnlpfjh, jsjames, theater, tavalin, mvalla and ArjenKorevaar October 29, 2023 09:19

lsiepel requested a review from lolodomo October 29, 2023 09:25

jlaur reviewed Oct 29, 2023

View reviewed changes

bundles/org.openhab.binding.senechome/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved

lolodomo requested changes Nov 3, 2023

View reviewed changes

querdenker2k and others added 4 commits November 4, 2023 06:36

Update bundles/org.openhab.binding.senechome/src/main/resources/OH-IN…

00dd669

…F/thing/thing-types.xml Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Robert D. <[email protected]>

code review changes

7c5ab34

Signed-off-by: querdenker2k <[email protected]>

Merge remote-tracking branch 'origin/fix-for-senec-update' into fix-f…

1c9c0b5

…or-senec-update

code review changes

8782662

Signed-off-by: querdenker2k <[email protected]>

lolodomo approved these changes Nov 11, 2023

View reviewed changes

lolodomo merged commit 1eacf67 into openhab:main Nov 11, 2023
2 of 3 checks passed

lolodomo added this to the 4.1 milestone Nov 11, 2023

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023

[Senec] Fix for Senec firmware update (openhab#15535)

4560ec9

* Fix for Senec update Signed-off-by: querdenker2k <[email protected]>

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024

[Senec] Fix for Senec firmware update (openhab#15535)

4eccd9f

* Fix for Senec update Signed-off-by: querdenker2k <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>

jlaur changed the title ~~[Senec] Fix for Senec firmware update~~ [senechome] Fix for Senec firmware update Jun 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[senechome] Fix for Senec firmware update #15535

[senechome] Fix for Senec firmware update #15535

querdenker2k commented Sep 1, 2023 •

edited by lsiepel

Loading

eguib commented Sep 5, 2023 •

edited

Loading

eguib commented Sep 6, 2023

vich-667 commented Sep 10, 2023

lolodomo commented Oct 18, 2023 •

edited

Loading

vich-667 commented Oct 20, 2023

lsiepel commented Oct 29, 2023

lolodomo left a comment

lolodomo left a comment

lolodomo commented Nov 11, 2023

lolodomo commented Nov 11, 2023

wborn commented Nov 11, 2023

lolodomo commented Nov 11, 2023

wborn commented Nov 11, 2023

[senechome] Fix for Senec firmware update #15535

[senechome] Fix for Senec firmware update #15535

Conversation

querdenker2k commented Sep 1, 2023 • edited by lsiepel Loading

eguib commented Sep 5, 2023 • edited Loading

eguib commented Sep 6, 2023

vich-667 commented Sep 10, 2023

lolodomo commented Oct 18, 2023 • edited Loading

vich-667 commented Oct 20, 2023

lsiepel commented Oct 29, 2023

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo commented Nov 11, 2023

lolodomo commented Nov 11, 2023

wborn commented Nov 11, 2023

lolodomo commented Nov 11, 2023

wborn commented Nov 11, 2023

querdenker2k commented Sep 1, 2023 •

edited by lsiepel

Loading

eguib commented Sep 5, 2023 •

edited

Loading

lolodomo commented Oct 18, 2023 •

edited

Loading