[monopriceaudio] Fix reconnect error race condition #15536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <[email protected]>
|
@jlaur Can this be considered if another 4.0.x patch release is done? |
jlaur
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Michael Lobstein <[email protected]>
It seems low-risk, so let's do that. I have cherry-picked the commit for being included in 4.0.4 when that happens. |
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
Signed-off-by: Michael Lobstein <[email protected]>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: querdenker2k <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition that occurs during reconnect when the binding disconnects before the initial status query responses are received. The polling job will still determine when the amplifier is no longer responding and set the thing status appropriately.