[fineoffsetweatherstation] Fix wrong handling temperature reading for of WH34 #15853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Berger <[email protected]>
Andy2003
force-pushed
the
feature/fine-offset-weather-station-debug-info
branch
from
2a9a67f
to
8990327
Compare
Andy2003
added
bug
Andy2003
changed the title
… of WH34 Signed-off-by: Andreas Berger <[email protected]>
Andy2003
force-pushed
the
feature/fine-offset-weather-station-debug-info
branch
from
f989045
to
de5893b
Compare
jlaur
approved these changes
Nov 10, 2023
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
… of WH34 (openhab#15853) * [fineoffsetweatherstation] Improve tracing * [fineoffsetweatherstation] Fix wrong handling temperature reading for of WH34 Signed-off-by: Andreas Berger <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
… of WH34 (openhab#15853) * [fineoffsetweatherstation] Improve tracing * [fineoffsetweatherstation] Fix wrong handling temperature reading for of WH34 Signed-off-by: Andreas Berger <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong handling temperature reading for of WH34
As discovered by a community member in https://community.openhab.org/t/fine-offset-weather-station-binding-discussion/134167/240 there was an issue while reading data from the WH34 Sensor resulting in all sensor readings following this sensor stop working.
Additionally the tracing for such errors has been improved, so that the byte sequence is split up to understand what each byte of the message means.
Example log output: