Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tasmotaplug] Initial contribution #15857

Merged
merged 11 commits into from
Nov 10, 2023
Merged

[tasmotaplug] Initial contribution #15857

merged 11 commits into from
Nov 10, 2023

Conversation

mlobstein
Copy link
Contributor

New binding to support Tasmota flashed smart plugs with 1, 2, 3 or 4 relay channels

@mlobstein mlobstein added the new binding If someone has started to work on a binding. For a new binding PR. label Nov 7, 2023
@mlobstein mlobstein requested a review from a team as a code owner November 7, 2023 01:37
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tasmota-plug-binding-3-2-0-4-1-0/146039/1

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! The code looks very clean, and I have only added a few minor comments.

Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein mlobstein requested a review from jlaur November 8, 2023 23:49
Signed-off-by: Michael Lobstein <[email protected]>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, while proof-reading the documentation I stumbled across one minor thing leading me to a small issue with one of the parameters. This should be my last review iteration. 🙂

Signed-off-by: Michael Lobstein <[email protected]>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quickly addressing the few comments.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

@jlaur jlaur merged commit ffc127f into openhab:main Nov 10, 2023
3 checks passed
@jlaur jlaur added this to the 4.1 milestone Nov 10, 2023
@mlobstein
Copy link
Contributor Author

LGTM, thanks for quickly addressing the few comments.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

Opened a PR to add the logo: openhab/openhab-docs#2151

@mlobstein mlobstein deleted the tasmotaplug branch November 10, 2023 23:18
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants