-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tasmotaplug] Initial contribution #15857
Conversation
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/tasmota-plug-binding-3-2-0-4-1-0/146039/1 |
Signed-off-by: Michael Lobstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! The code looks very clean, and I have only added a few minor comments.
bundles/org.openhab.binding.tasmotaplug/src/main/resources/OH-INF/addon/addon.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tasmotaplug/src/main/resources/OH-INF/i18n/tasmotaplug.properties
Outdated
Show resolved
Hide resolved
...otaplug/src/main/java/org/openhab/binding/tasmotaplug/internal/TasmotaPlugConfiguration.java
Outdated
Show resolved
Hide resolved
...aplug/src/main/java/org/openhab/binding/tasmotaplug/internal/handler/TasmotaPlugHandler.java
Outdated
Show resolved
Hide resolved
...aplug/src/main/java/org/openhab/binding/tasmotaplug/internal/handler/TasmotaPlugHandler.java
Show resolved
Hide resolved
...aplug/src/main/java/org/openhab/binding/tasmotaplug/internal/handler/TasmotaPlugHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tasmotaplug/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
...otaplug/src/main/java/org/openhab/binding/tasmotaplug/internal/TasmotaPlugConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, while proof-reading the documentation I stumbled across one minor thing leading me to a small issue with one of the parameters. This should be my last review iteration. 🙂
bundles/org.openhab.binding.tasmotaplug/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...aplug/src/main/java/org/openhab/binding/tasmotaplug/internal/handler/TasmotaPlugHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for quickly addressing the few comments.
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website
Opened a PR to add the logo: openhab/openhab-docs#2151 |
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
New binding to support Tasmota flashed smart plugs with 1, 2, 3 or 4 relay channels