Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[energidataservice] Add support for persisting historical and upcoming prices #15864

Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Nov 7, 2023

Implement time series support introduced by openhab/openhab-core#3597.

This is transparent to users, no matter if persistence is configured or not. If persistence is configured, future prices will now also be persisted when they become available. It is recommended to configure persistence strategy forecast to avoid redundant updates. This has been added to the documentation. One noticeable change when looking at persisted timestamps:

Previously - last three persisted spot prices:

2023-11-09 19:00:00.005, 0.9290125275
2023-11-09 20:00:00.010, 0.77621246375
2023-11-09 21:00:00.028, 0.74480003375

Now:

2023-11-09 21:00:00.000, 0.74480003375
2023-11-09 22:00:00.000, 0.73518753
2023-11-09 23:00:00.000, 0.69323753375

As seen in the UI per 2023-11-09 with the VAT Profile applied (see #15873):
image

Resolves #15863

@jlaur jlaur force-pushed the 15863-energidataservice-persist-future-prices branch from 9a795fd to 5204dcc Compare November 7, 2023 21:32
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Nov 7, 2023
@jlaur jlaur force-pushed the 15863-energidataservice-persist-future-prices branch from 5204dcc to fb490bd Compare November 8, 2023 16:28
@jlaur jlaur changed the title [energidataservice] Persist future prices [energidataservice] Add support for persisting historic/future prices Nov 9, 2023
@jlaur jlaur marked this pull request as ready for review November 9, 2023 18:29
@jlaur jlaur force-pushed the 15863-energidataservice-persist-future-prices branch 2 times, most recently from cfd2943 to 914a676 Compare November 9, 2023 19:22
Resolves openhab#15863

Signed-off-by: Jacob Laursen <[email protected]>
@jlaur jlaur force-pushed the 15863-energidataservice-persist-future-prices branch from 914a676 to c085869 Compare November 9, 2023 19:27
@jlaur jlaur changed the title [energidataservice] Add support for persisting historic/future prices [energidataservice] Add support for persisting historical and upcoming prices Nov 9, 2023
@jlaur jlaur requested a review from a team November 9, 2023 20:09
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/bringing-electricity-information-from-eloverblik-dk-and-energidataservice-dk-into-openhab/143470/65

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 50e1687 into openhab:main Nov 11, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 11, 2023
@jlaur jlaur deleted the 15863-energidataservice-persist-future-prices branch November 11, 2023 14:46
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Resolves openhab#15863

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[energidataservice] Persist future prices
3 participants