Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdpowerview] Improve color channel for Repeater and remove redundant brightness channel #15880

Merged
merged 2 commits into from
Nov 18, 2023
Merged

[hdpowerview] Improve color channel for Repeater and remove redundant brightness channel #15880

merged 2 commits into from
Nov 18, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Nov 11, 2023 •
edited
Loading

Improve handling of color channel:

  • Brightness can now be set through a Color item (previously it was overridden by device value).
  • Brightness commands are now supported.
  • Black is now correctly interpreted as off.
  • Turning on from black now works correctly.
  • RGB color value is now preserved when turning off (and restored when turning on).
  • Increase/decrease commands are now supported.

Remove redundant channel brightness introduced by #12308 because I didn't know better at the time.

And last, remove unused update instructions from #13355:

  • Property thingTypeVersion was not supplied, so no update was ever triggered.
  • The thing type UID powerview:shade was invalid, should have been hdpowerview:shade.
  • I'm not sure why they were there in the first place, because the channels were not changed.
  • I never saw any complaints, so I don't think there is anything to fix, and therefore removed them in order to clean up.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Nov 11, 2023
@jlaur jlaur mentioned this pull request Nov 11, 2023
Merged
andrewfg
andrewfg approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an actual repeater, so I can't test it, but from just looking at the code - LGTM

@jlaur jlaur force-pushed the hdpowerview-repeater-brightness branch 4 times, most recently from 8369788 to d73df69 Compare November 11, 2023 23:50
@jlaur jlaur changed the title [hdpowerview] Remove redundant brightness channel [hdpowerview] Improve color channel for Repeater and remove redundant brightness channel Nov 12, 2023
@jlaur jlaur force-pushed the hdpowerview-repeater-brightness branch from d73df69 to 18ac87e Compare November 12, 2023 21:45
@jlaur jlaur marked this pull request as ready for review November 12, 2023 21:57
@jlaur jlaur requested a review from a team November 12, 2023 22:07
@jlaur jlaur force-pushed the hdpowerview-repeater-brightness branch from 18ac87e to c28fd54 Compare November 13, 2023 18:53
@jlaur
Improve color channel
cecfc19 
Remove redundant brightness channel

Signed-off-by: Jacob Laursen <[email protected]>
@jlaur jlaur force-pushed the hdpowerview-repeater-brightness branch from c28fd54 to cecfc19 Compare November 13, 2023 18:56
lolodomo
lolodomo approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 7d24cfb into openhab:main Nov 18, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 18, 2023
@jlaur jlaur mentioned this pull request Nov 18, 2023
Merged
@jlaur jlaur deleted the hdpowerview-repeater-brightness branch November 18, 2023 15:50
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@jlaur @andrewfg
[hdpowerview] Improve color channel for Repeater and remove redundant…
90d2d83 
… brightness channel (openhab#15880)

* Improve color channel
* Log warning for unexpected color command

---------

Signed-off-by: Jacob Laursen <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
[hdpowerview] Improve color channel for Repeater and remove redundant…
d28c860 
… brightness channel (openhab#15880)

* Improve color channel
* Log warning for unexpected color command

---------

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@andrewfg andrewfg andrewfg approved these changes

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jlaur @andrewfg @lolodomo