Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] VETO updates to read only channels #15937

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 20, 2023

I.e. Button, Scene, and Binary Sensors.

Also ensure we set up the CommandDescription, since some value types mights use it.

I.e. Button, Scene, and Binary Sensors.

Also ensure we set up the CommandDescription, since some value types mights use it.

Signed-off-by: Cody Cutrer <[email protected]>
@antroids
Copy link
Contributor

LGTM,
will this change how read-only switches work on the Sitemap UI?

@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 21, 2023

This prevents the state of the item from changing if you accidentally send a command to it (via UI or rules). openhab/openhab-core#3877 is what should prevent it from showing up as a switch in BasicUI.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 935415a into openhab:main Nov 25, 2023
3 checks passed
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Nov 25, 2023
@lolodomo lolodomo added this to the 4.1 milestone Nov 25, 2023
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
I.e. Button, Scene, and Binary Sensors.

Also ensure we set up the CommandDescription, since some value types mights use it.

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer deleted the mqtt-homeassistant-veto-readonly branch November 29, 2023 22:45
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
I.e. Button, Scene, and Binary Sensors.

Also ensure we set up the CommandDescription, since some value types mights use it.

Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants