[solax] Implement refresh command and improve thread safety #15958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
theater
commented
Nov 25, 2023
theater
commented
- Added a refresh command
- Implemented a reentrant lock when we retrieve the data via http call so we don't do multiple calls to the same server unless the first call has returned data or timed out. There is no point to flood it as probably it's not very powerful device anyway.
Signed-off-by: Konstantin Polihronov <[email protected]>
theater
added
the
enhancement
lolodomo
reviewed
Nov 25, 2023
....binding.solax/src/main/java/org/openhab/binding/solax/internal/SolaxLocalAccessHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Konstantin Polihronov <[email protected]>
theater
force-pushed
the
solax_refresh_command
branch
from
9756bbf
to
97ae57a
Compare
jlaur
changed the title
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…penhab#15958) * Implementation of refresh command and better multi-thread handling --------- Signed-off-by: Konstantin Polihronov <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.