-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hue] Use auto update policy 'veto' for light channels (API v2) #15984
Conversation
c863a57
to
a0df376
Compare
@jlaur as you added a description text to some of the channels, perhaps you need to run update properties script to update the .properties file? Or? |
a0df376
to
59202e8
Compare
Yes, thanks for the reminder, it was done. Ready for final review. |
fe69b81
to
5f6e124
Compare
Resolves openhab#15983 Signed-off-by: Jacob Laursen <[email protected]>
5f6e124
to
d61e828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kaikreuzer - could I indiscreetly bring this to your attention as well? 😉 That would give @andrewfg and I a good baseline for the next PR's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlaur certainly any time!
Thanks for this improvement!
Resolves openhab#15983 Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/philips-hue-clip-2-api-v2-discussion-thread/142111/502 |
This pull request addresses an issue with auto update policy being default, which causes commands to trigger state update immediately rather than awaiting the final state from the bridge.
This can cause:
Example:
Or even worse:
With auto update policy veto:
and:
Using auto update policy veto will allow us to await the final state from the bridge. This will happen quite quickly since we receive events through SSE with API v2.
Fixes #15983
Related to #15700, #15995
Depends on openhab/openhab-core#3888