[flume] Initial contribution

[jsjames]

This is a new binding to read water usage when using a flume water meter device (https://flumewater.com/). It utilizes the Flume cloud API (https://flumetech.readme.io/reference/introduction).

A built version of the binding is at this location: https://drive.google.com/file/d/13lnVOnUnVKCdudOXF7crdGdTNEL_ACW6/view?usp=drive_link

[lsiepel]

Thank you for this contribution. As there are many PR’s to review, it would nice if you can do some self review upfront. A checklist is here https://github.com/openhab/openhab-addons/wiki/Review-Checklist

I noticed that the channel id’s and maybe more do not match the naming convention. For reference https://www.openhab.org/docs/developer/guidelines.html#naming-convention

Please ping me when you are ready.

[jsjames]

Thank you for this contribution. As there are many PR’s to review, it would nice if you can do some self review upfront. A checklist is here https://github.com/openhab/openhab-addons/wiki/Review-Checklist

I noticed that the channel id’s and maybe more do not match the naming convention. For reference https://www.openhab.org/docs/developer/guidelines.html#naming-convention

Please ping me when you are ready.

@lsiepel - I addressed the naming convention in this commit and I did go back through the checklist/code guidelines and "believe" everything is in a good state.

[digitaldan]

Thanks for the binding @jsjames , my flume2 comes today so very excited to hook it up to openHAB and tie it in with my sprinkler monitoring (Hydrawsie binding) . I'll let you know how it goes !

[lsiepel]

Thanks again for this contribution. Just finish this partial review, looked at 25/32 files. Looks pretty good, some comments and questions for now. Hope to finish this review later this week.

[jsjames]

Thanks for the binding @jsjames , my flume2 comes today so very excited to hook it up to openHAB and tie it in with my sprinkler monitoring (Hydrawsie binding) . I'll let you know how it goes !

@digitaldan, it will be good to know how you end up linking them. I am using the rachio binding which notified when a zone is turned on/off. I persist both that and the cumulative water usage into influx. Then, I use a "very complex" flux query to retrieve the data. Its somewhat error prone and influxdb is deprecating the flux language - so i'm planning to use a different method. Hope the binding will work well for you.

[jsjames]

Last part of the review. Nice to see all features like i18n are in place. Thanks again. Left some questions and comments. Ping me when you are ready.

@lsiepel - I marked the items resolved, but have to still push the changes into the repository. Was going to let it run tonight to confirm everything works and will push up the changes tomorrow. Anyway, don't merge changes quite yet. thanks.

Yes I know still have to verify the changes.

Sounds good, i just saw you marked as approved. Should be good to go now. I streamlined/refactored some of the API calls, so there are quite a few changes to that file - but it is better structured.

[lsiepel]

Very minor comment and the i18n plugin has to be re-run. Otherwise LGTM.

[lsiepel]

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

[jsjames]

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

@lsiepel - Thanks for all you do to make us all better coders!!