-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][linky] Initial commit of Enedis Linky binding #6926
Conversation
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
😎 What usage do you imagine in a HA system? This will mainly be used to display graphs in openHAB? Something you can have probably with a better rendering in their mobile app? |
Why did you use OkHttpClient? |
Not 100% sure what can be done with this, instead of warning when usage increases outstandingly toward usual trend.
I know but the examples I had were based on OkHttpClient and I was focused on having something that works rather than how it works. Enedis website is not really 'great' so I prefered using something proven. |
You certainly know it but the openHAB core framework is providing a HTTP client abstraction (currently based on Jetty HTTP client) that should be used by any binding using HTTP requests. |
Your cookies stuff could be a problem if we want rather use the core framework. Not sure something similar is provided. |
You are right, we can imagine a threshold that would trigger a rule. A user rule could then power off something as an example. |
I read that the cookies are handled by the Jetty HTTP client. |
Great ! |
@clinique : I just pushed a change to your repo. I was not expecting a direct merge ! I am very sorry, I thought it will appear as a simple PR to be reviewed by you in your repo. This change is an attempt to remove okhttp usage from your binding and rather use the HTTP util code from the openHAB core framework. I am waiting for my password (I should receive it in few days by postal mail - the process to open an account is a little frustating) so I was not able to test the code, neither yours nor mine. |
It is possible that the values in the body like the username and the password have to be encoded in case they contain a non standard characters. |
bundles/org.openhab.binding.linky/src/main/resources/ESH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.linky/src/main/resources/ESH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.linky/src/main/resources/ESH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.linky/src/main/resources/ESH-INF/thing/thing-types.xml
Show resolved
Hide resolved
...ab.binding.linky/src/main/java/org/openhab/binding/linky/internal/LinkyBindingConstants.java
Outdated
Show resolved
Hide resolved
...ab.binding.linky/src/main/java/org/openhab/binding/linky/internal/LinkyBindingConstants.java
Outdated
Show resolved
Hide resolved
...ab.binding.linky/src/main/java/org/openhab/binding/linky/internal/LinkyBindingConstants.java
Outdated
Show resolved
Hide resolved
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Show resolved
Hide resolved
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Outdated
Show resolved
Hide resolved
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Outdated
Show resolved
Hide resolved
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.linky/src/main/resources/ESH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
I saw that I forgot the non null by default annotation in the console extension class. Can you add it ? |
Travis tests have failedHey @clinique, 1st BuildExpand here
|
Travis tests were successfulHey @clinique, |
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
…a that will fail Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Alos suppress now useless configuration setting Update README Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Try 4 times per day to retrieve valid data Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
@lolodomo : I'm in the middle of a nightmare trying to rebase/squash this PR. I'm going to close this PR and create a new one. |
Travis tests have failedHey @clinique, 2nd BuildExpand here
|
Signed-off-by: Gaël L'hopital [email protected]