-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSL] Expose ColorUtil methods to DSL rules #3749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
force-pushed
the
ColorUtil_DSL
branch
from
August 11, 2023 19:28
52f354c
to
9063a71
Compare
With the following rule:
here is the result when I select color with the color picker:
|
Fix openhab#3743 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
ColorUtil_DSL
branch
from
August 12, 2023 08:54
9063a71
to
144636c
Compare
Once merged, I will create a PR to enhance the openHAB documentation. |
Any chance this PR gets merged? |
kaikreuzer
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
lolodomo
added a commit
to lolodomo/openhab-docs
that referenced
this pull request
Nov 12, 2023
Related to openhab/openhab-core#3749 Signed-off-by: Laurent Garnier <[email protected]>
stefan-hoehn
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Nov 19, 2023
* Add color utils actions Related to openhab/openhab-core#3749 Signed-off-by: Laurent Garnier <[email protected]> * Review comment: remove a blank line Signed-off-by: Laurent Garnier <[email protected]> --------- Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3743
Signed-off-by: Laurent Garnier [email protected]