Add conversion for HSB to RGBW and back #3849

genesis81 · 2023-10-17T21:22:51Z

For KNX DPT251.600 to use all 4 colors.

With the new feature, the HSBType can converted into RGBW, and also back to HSB.

Due to the conversion, some accuracy is lost, but the result is approximately correct.

J-N-K

Thanks for your contribution. Looks like a useful addition. I have left some comments.

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

holgerfriedrich

Hi @genesis81, it is good to introduce RGBW as well.

I have added my thoughts regarding style, but also regarding the interfaces an how this fits to the existing methods for RGB.

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

bundles/org.openhab.core/src/test/java/org/openhab/core/util/ColorUtilTest.java

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

holgerfriedrich

thanks, just a few last comments....

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

genesis81 · 2023-11-09T20:19:14Z

thanks, just a few last comments....

No problem, i add the points. Thanks for review.

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

holgerfriedrich

LGTM, thanks.

J-N-K

I only left some comments regarding the variable naming. Please also adjust that in the other direction. Once that is done, we are good to go. Please make sure that all names start with a lower case letter.

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

for KNX DPT251.600 to use all 4 colors. With the new feature, the HSBType can converted into RGBW, and also back to HSB. Due to the conversion, some accuracy is lost, but the result is approximately correct. Signed-off-by: Marco Müller <[email protected]>

Signed-off-by: Marco Müller <[email protected]>

J-N-K

hsbToRgbwPercent looks good now. As I said in my last review: please also apply that to rgbwToHsb.

Signed-off-by: Marco Müller <[email protected]>

J-N-K

Thanks!

New functions for RGBW introduced in openhab#3849. Signed-off-by: Holger Friedrich <[email protected]>

New functions for RGBW introduced in #3849. Signed-off-by: Holger Friedrich <[email protected]>

jlaur · 2023-11-25T10:41:17Z

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java

+    }
+
+    /**
+     * Transform <a href="https://en.wikipedia.org/wiki/HSL_and_HSV">HSV</a> based {@link HSBType} to RGBW.


I just found this PR and was interested because I think this method could be used instead of doing two passes here:
https://github.com/openhab/openhab-addons/blob/a13fd80bfe5cf0b6c55e13756f42abc27b55796b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewRepeaterHandler.java#L264-L265

Anyway, commenting because this description seems to be copied from the method for the other direction. This one is RGBW to HSBType.

thanks, included in #3882

openhab-bot · 2024-02-19T09:27:20Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hue-bulb-changing-color-wrongly-when-brightness-is-0/154005/8

genesis81 requested a review from a team as a code owner October 17, 2023 21:22

genesis81 mentioned this pull request Oct 17, 2023

[knx] Change the conversion of the DPT251.600 to use RGB and White. openhab/openhab-addons#15773

Closed

genesis81 force-pushed the main branch from 6f8dab1 to 15284d8 Compare October 17, 2023 21:48

genesis81 changed the title ~~Add conversion for HSB to RGBW and back~~ [core] Add conversion for HSB to RGBW and back Oct 17, 2023

genesis81 force-pushed the main branch 2 times, most recently from 1bb3ef0 to 2571f77 Compare October 17, 2023 21:58

J-N-K requested changes Nov 1, 2023

View reviewed changes

genesis81 force-pushed the main branch from f73e748 to adf0848 Compare November 1, 2023 21:04

holgerfriedrich requested changes Nov 1, 2023

View reviewed changes

holgerfriedrich requested changes Nov 8, 2023

View reviewed changes

genesis81 requested a review from J-N-K November 9, 2023 20:45

holgerfriedrich reviewed Nov 9, 2023

View reviewed changes

bundles/org.openhab.core/src/main/java/org/openhab/core/util/ColorUtil.java Outdated Show resolved Hide resolved

holgerfriedrich approved these changes Nov 9, 2023

View reviewed changes

J-N-K requested changes Nov 11, 2023

View reviewed changes

genesis81 force-pushed the main branch from 5f60723 to 1803cc1 Compare November 11, 2023 19:44

genesis81 added 8 commits November 11, 2023 21:53

Simplify calculation

feae11e

Signed-off-by: Marco Müller <[email protected]>

Remove not used constant

55910fd

Signed-off-by: Marco Müller <[email protected]>

Change naming and rewrite functions

ef91ee1

Signed-off-by: Marco Müller <[email protected]>

Fix Bugs.

d91930f

Signed-off-by: Marco Müller <[email protected]>

Some changes in comments. Add hsbToRgbw

503b876

Signed-off-by: Marco Müller <[email protected]>

Change javadoc

768dd1c

Signed-off-by: Marco Müller <[email protected]>

Naming

084488e

Signed-off-by: Marco Müller <[email protected]>

genesis81 force-pushed the main branch from 1803cc1 to 084488e Compare November 11, 2023 22:30

genesis81 requested a review from J-N-K November 12, 2023 08:44

J-N-K reviewed Nov 12, 2023

View reviewed changes

Naming variables in rgbwToHsb

fe49083

Signed-off-by: Marco Müller <[email protected]>

J-N-K approved these changes Nov 12, 2023

View reviewed changes

J-N-K added the enhancement An enhancement or new feature of the Core label Nov 12, 2023

J-N-K added this to the 4.1 milestone Nov 12, 2023

J-N-K merged commit 237f2eb into openhab:main Nov 12, 2023
3 checks passed

J-N-K changed the title ~~[core] Add conversion for HSB to RGBW and back~~ Add conversion for HSB to RGBW and back Nov 12, 2023

holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Nov 21, 2023

[DSL] Expose ColorUtil methods to DSL rules

5d86b77

New functions for RGBW introduced in openhab#3849. Signed-off-by: Holger Friedrich <[email protected]>

holgerfriedrich mentioned this pull request Nov 21, 2023

[DSL] Expose ColorUtil methods to DSL rules #3879

Merged

kaikreuzer pushed a commit that referenced this pull request Nov 22, 2023

[DSL] Expose ColorUtil methods to DSL rules (#3879)

3e3afd8

New functions for RGBW introduced in #3849. Signed-off-by: Holger Friedrich <[email protected]>

jlaur reviewed Nov 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add conversion for HSB to RGBW and back #3849

Add conversion for HSB to RGBW and back #3849

genesis81 commented Oct 17, 2023

J-N-K left a comment

holgerfriedrich left a comment

holgerfriedrich left a comment

genesis81 commented Nov 9, 2023

holgerfriedrich left a comment

J-N-K left a comment

J-N-K left a comment

J-N-K left a comment

jlaur Nov 25, 2023

holgerfriedrich Nov 25, 2023

openhab-bot commented Feb 19, 2024

Add conversion for HSB to RGBW and back #3849

Add conversion for HSB to RGBW and back #3849

Conversation

genesis81 commented Oct 17, 2023

J-N-K left a comment

Choose a reason for hiding this comment

holgerfriedrich left a comment

Choose a reason for hiding this comment

holgerfriedrich left a comment

Choose a reason for hiding this comment

genesis81 commented Nov 9, 2023

holgerfriedrich left a comment

Choose a reason for hiding this comment

J-N-K left a comment

Choose a reason for hiding this comment

J-N-K left a comment

Choose a reason for hiding this comment

J-N-K left a comment

Choose a reason for hiding this comment

jlaur Nov 25, 2023

Choose a reason for hiding this comment

holgerfriedrich Nov 25, 2023

Choose a reason for hiding this comment

openhab-bot commented Feb 19, 2024