[sitemap] Buttongrid with Button components available for main UI configuration #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
mherwege
force-pushed
the
buttongrid
branch
from
f1fccc2
to
d992fa3
Compare
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Oct 4, 2024
Refs openhab/openhab-core#4377. The most recent addition to the sitemap syntax allows defining buttons nested as components inside the Buttongrid component. --------- Signed-off-by: Mark Herwege <[email protected]>
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Oct 5, 2024
Refs openhab/openhab-core#4377. The most recent addition to the sitemap syntax allows defining buttons nested as components inside the Buttongrid component. --------- Signed-off-by: Mark Herwege <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax using nested Button components inside a Buttongrid component is currently not supported for configuration in the UI. This adds the necessary logic in core to make this possible.
@lolodomo
Related to #4223. This PR did not include the necessary part for UI sitemap configuration.