Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSE streams when using GZIP #1476

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Fix SSE streams when using GZIP #1476

merged 2 commits into from
Mar 5, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Mar 5, 2023

Fixes openhab/openhab-webui#1757

It seems that enabling GZIP for the SSE endpoints breaks the ecent stream.

@J-N-K
Fix SSE streams when using GZIP
949c3d6 
It seems that enabling GZIP for the SSE endpoints breaks the ecent stream.

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K requested a review from a team as a code owner March 5, 2023 13:33
@wborn
Copy link
Member

wborn commented Mar 5, 2023

Did you also consider to only include the mime types that are known to work by calling addIncludedMimeTypes? If that works we won't have to manage the list of endpoints.

@J-N-K
address review comment
13ff9e4 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K
Copy link
Member Author

J-N-K commented Mar 5, 2023

That also works.

wborn
wborn approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@wborn wborn merged commit 5bf68b6 into openhab:main Mar 5, 2023
@wborn wborn added this to the 4.0 milestone Mar 5, 2023
@wborn wborn added bug An unexpected problem or unintended behavior regression Regression that happened during the development of a release. Not shown on final release notes. labels Mar 5, 2023
@J-N-K J-N-K deleted the fix-sse branch March 5, 2023 16:39
@lolodomo
Copy link
Contributor

lolodomo commented Mar 5, 2023

I just tested with this version of jetty.xml and it also works again for me.
Thank you.

@lolodomo lolodomo mentioned this pull request Mar 5, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[BasicUI] Live update is fully unstable with OH 4.1.1 and Firefox 121.0.1
3 participants
@J-N-K @wborn @lolodomo