[webaudio] Allow stopping play #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #1240: Bundle Size — 15.75MiB (-0.08%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1240 report View dalgwen:webaudio_stop branch activity |
ghys
added
enhancement
dalgwen
force-pushed
the
webaudio_stop
branch
from
393fe6a
to
c384a21
Compare
dalgwen
force-pushed
the
webaudio_stop
branch
from
c384a21
to
bd356a7
Compare
Use of a dictionary to store audio sources currently playing and stop them all when asked to. A corresponding core (webaudio sink) modification is following. Signed-off-by: Gwendal Roulleau <[email protected]>
dalgwen
force-pushed
the
webaudio_stop
branch
from
bd356a7
to
954355d
Compare
|
Thanks @florian-h05 for removing the "awaiting other PR" tag, as the core pull request was indeed merged. I rebased the code (as the "play" part moves to another file), and it is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of a dictionary to store audio sources currently playing and stop them all when asked to.
Refs openhab/openhab-core#3766.
Signed-off-by: Gwendal Roulleau [email protected]